Skip to content

Commit 2084a70

Browse files
weiguangli-ioclaude
andcommitted
refactor(test): simplify metadata assertions with object equality
Applied Gemini Code Assist suggestion to make test more concise and maintainable by using direct object comparison instead of field-by-field assertions. Pydantic models support equality comparison natively. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 07a9526 commit 2084a70

File tree

1 file changed

+2
-13
lines changed

1 file changed

+2
-13
lines changed

tests/unittests/sessions/test_vertex_ai_session_service.py

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -960,17 +960,6 @@ async def test_append_event_with_cache_and_usage_metadata():
960960

961961
appended_event = retrieved_session.events[-1]
962962
# cache_metadata is preserved
963-
assert appended_event.cache_metadata is not None
964-
assert appended_event.cache_metadata.cache_name == (
965-
'projects/123/locations/us-central1/cachedContents/456'
966-
)
967-
assert appended_event.cache_metadata.fingerprint == 'abc123hash'
968-
assert appended_event.cache_metadata.invocations_used == 3
969-
assert appended_event.cache_metadata.contents_count == 10
970-
assert appended_event.cache_metadata.created_at == 1700000000.0
963+
assert appended_event.cache_metadata == cache_meta
971964
# usage_metadata is preserved
972-
assert appended_event.usage_metadata is not None
973-
assert appended_event.usage_metadata.prompt_token_count == 100
974-
assert appended_event.usage_metadata.candidates_token_count == 50
975-
assert appended_event.usage_metadata.total_token_count == 150
976-
assert appended_event.usage_metadata.cached_content_token_count == 80
965+
assert appended_event.usage_metadata == usage_meta

0 commit comments

Comments
 (0)