Commit 5a56f91
Nishar
fix: make temp: state keys accessible in session.state during invocation
Fixes #3047
temp: prefixed state keys (e.g. set via output_key='temp:...') were
being dropped from session.state before lifecycle callbacks could
read them.
Root cause: BaseSessionService.__update_session_state() explicitly
skipped keys starting with 'temp:', preventing them from ever
reaching session.state.
Changes:
- base_session_service.py: Remove the temp: skip in
__update_session_state() so all keys flow into the in-memory
session.state.
- in_memory_session_service.py: Strip temp: keys from
event.actions.state_delta after updating the caller's session but
before writing to the storage session, preventing temp keys from
leaking into persisted state.
- test_session_service.py: Update existing tests to reflect that
temp: keys are now accessible in-memory, and add a dedicated
regression test.
Temp keys remain non-persistent:
- DatabaseSessionService uses _extract_state_delta() which already
filters temp: keys before writing to the database.
- InMemorySessionService now strips temp: keys before updating
shared state stores and the storage session.
- Runner creates a deepcopy of session at invocation start,
preventing temp keys from leaking across invocations.1 parent c224626 commit 5a56f91
3 files changed
Lines changed: 56 additions & 8 deletions
File tree
- src/google/adk/sessions
- tests/unittests/sessions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
| 106 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
259 | 259 | | |
260 | 260 | | |
261 | 261 | | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
262 | 270 | | |
263 | 271 | | |
264 | 272 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
156 | 156 | | |
157 | 157 | | |
158 | 158 | | |
159 | | - | |
| 159 | + | |
160 | 160 | | |
161 | 161 | | |
162 | 162 | | |
163 | | - | |
| 163 | + | |
164 | 164 | | |
165 | 165 | | |
166 | 166 | | |
| |||
218 | 218 | | |
219 | 219 | | |
220 | 220 | | |
221 | | - | |
| 221 | + | |
222 | 222 | | |
223 | 223 | | |
224 | 224 | | |
225 | | - | |
| 225 | + | |
226 | 226 | | |
227 | 227 | | |
228 | 228 | | |
| |||
377 | 377 | | |
378 | 378 | | |
379 | 379 | | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
0 commit comments