Skip to content

Commit 77d5b5c

Browse files
RKestcopybara-github
authored andcommitted
refactor(telemetry): rename duration metrics to GenAI semconv operation names
Rename gen_ai.agent.invocation.duration to gen_ai.invoke_agent.duration and gen_ai.tool.execution.duration to gen_ai.execute_tool.duration so the metric names match the GenAI semantic-convention operation names (invoke_agent, execute_tool) already used for the corresponding spans. Co-authored-by: Max Ind <maxind@google.com> PiperOrigin-RevId: 941394506
1 parent 7a553b7 commit 77d5b5c

5 files changed

Lines changed: 14 additions & 14 deletions

File tree

src/google/adk/telemetry/_metrics.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
)
4848

4949
_agent_invocation_duration = meter.create_histogram(
50-
"gen_ai.agent.invocation.duration",
50+
"gen_ai.invoke_agent.duration",
5151
unit="s",
5252
description="Duration of agent invocations.",
5353
explicit_bucket_boundaries_advisory=[
@@ -72,7 +72,7 @@
7272
description="Duration of workflow invocations.",
7373
)
7474
_tool_execution_duration = meter.create_histogram(
75-
"gen_ai.tool.execution.duration",
75+
"gen_ai.execute_tool.duration",
7676
unit="s",
7777
description="Duration of tool executions.",
7878
explicit_bucket_boundaries_advisory=[

tests/unittests/telemetry/functional_node_test_cases.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2581,13 +2581,13 @@
25812581

25822582
# Expected metric points, grouped by metric name.
25832583
EXPECTED_NODE_METRICS_V1: dict[str, frozenset[MetricPoint]] = {
2584-
"gen_ai.agent.invocation.duration": frozenset({
2584+
"gen_ai.invoke_agent.duration": frozenset({
25852585
MetricPoint(
25862586
attributes={"gen_ai.agent.name": AGENT_NAME},
25872587
value=NON_DETERMINISTIC,
25882588
),
25892589
}),
2590-
"gen_ai.tool.execution.duration": frozenset({
2590+
"gen_ai.execute_tool.duration": frozenset({
25912591
MetricPoint(
25922592
attributes={
25932593
"gen_ai.agent.name": AGENT_NAME,
@@ -2637,13 +2637,13 @@
26372637

26382638

26392639
EXPECTED_NODE_METRICS_V2: dict[str, frozenset[MetricPoint]] = {
2640-
"gen_ai.agent.invocation.duration": frozenset({
2640+
"gen_ai.invoke_agent.duration": frozenset({
26412641
MetricPoint(
26422642
attributes={"gen_ai.agent.name": AGENT_NAME},
26432643
value=NON_DETERMINISTIC,
26442644
),
26452645
}),
2646-
"gen_ai.tool.execution.duration": frozenset({
2646+
"gen_ai.execute_tool.duration": frozenset({
26472647
MetricPoint(
26482648
attributes={
26492649
"gen_ai.agent.name": AGENT_NAME,

tests/unittests/telemetry/functional_test_cases.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2275,13 +2275,13 @@
22752275

22762276
# Expected metric points, grouped by metric name.
22772277
EXPECTED_METRICS_V1: dict[str, frozenset[MetricPoint]] = {
2278-
"gen_ai.agent.invocation.duration": frozenset({
2278+
"gen_ai.invoke_agent.duration": frozenset({
22792279
MetricPoint(
22802280
attributes={"gen_ai.agent.name": AGENT_NAME},
22812281
value=NON_DETERMINISTIC,
22822282
),
22832283
}),
2284-
"gen_ai.tool.execution.duration": frozenset({
2284+
"gen_ai.execute_tool.duration": frozenset({
22852285
MetricPoint(
22862286
attributes={
22872287
"gen_ai.agent.name": AGENT_NAME,
@@ -2322,13 +2322,13 @@
23222322

23232323

23242324
EXPECTED_METRICS_V2: dict[str, frozenset[MetricPoint]] = {
2325-
"gen_ai.agent.invocation.duration": frozenset({
2325+
"gen_ai.invoke_agent.duration": frozenset({
23262326
MetricPoint(
23272327
attributes={"gen_ai.agent.name": AGENT_NAME},
23282328
value=NON_DETERMINISTIC,
23292329
),
23302330
}),
2331-
"gen_ai.tool.execution.duration": frozenset({
2331+
"gen_ai.execute_tool.duration": frozenset({
23322332
MetricPoint(
23332333
attributes={
23342334
"gen_ai.agent.name": AGENT_NAME,

tests/unittests/telemetry/functional_test_helpers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -307,12 +307,12 @@ class HistogramSpec(NamedTuple):
307307
HistogramSpec(
308308
module=_metrics,
309309
attr="_agent_invocation_duration",
310-
metric_name="gen_ai.agent.invocation.duration",
310+
metric_name="gen_ai.invoke_agent.duration",
311311
),
312312
HistogramSpec(
313313
module=_metrics,
314314
attr="_tool_execution_duration",
315-
metric_name="gen_ai.tool.execution.duration",
315+
metric_name="gen_ai.execute_tool.duration",
316316
),
317317
HistogramSpec(
318318
module=_metrics,

tests/unittests/telemetry/test_metrics.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,11 @@ def _mock_meter_setup(monkeypatch):
4545
client_token_usage_hist.name = "client_token_usage"
4646

4747
def create_histogram_side_effect(name, **_kwargs):
48-
if name == "gen_ai.agent.invocation.duration":
48+
if name == "gen_ai.invoke_agent.duration":
4949
return agent_duration_hist
5050
elif name == "gen_ai.invoke_workflow.duration":
5151
return workflow_duration_hist
52-
elif name == "gen_ai.tool.execution.duration":
52+
elif name == "gen_ai.execute_tool.duration":
5353
return tool_duration_hist
5454
elif name == "gen_ai.agent.request.size":
5555
return request_size_hist

0 commit comments

Comments
 (0)