Skip to content

Commit 83488ed

Browse files
committed
fix(models): register gemma 4 model names
1 parent 1445ad5 commit 83488ed

2 files changed

Lines changed: 15 additions & 1 deletion

File tree

src/google/adk/models/gemma_llm.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ def supported_models(cls) -> list[str]:
205205
"""
206206

207207
return [
208-
r'gemma-3.*',
208+
r'gemma-.*',
209209
]
210210

211211
@cached_property

tests/unittests/models/test_models.py

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414

1515
from google.adk import models
1616
from google.adk.models.anthropic_llm import Claude
17+
from google.adk.models.gemma_llm import Gemma
1718
from google.adk.models.google_llm import Gemini
1819
from google.adk.models.lite_llm import LiteLlm
1920
import pytest
@@ -56,6 +57,19 @@ def test_match_claude_family(model_name):
5657
assert models.LLMRegistry.resolve(model_name) is Claude
5758

5859

60+
@pytest.mark.parametrize(
61+
'model_name',
62+
[
63+
'gemma-3-27b-it',
64+
'gemma-4-27b-it',
65+
'gemma-4-31b-it',
66+
],
67+
)
68+
def test_match_gemma_family(model_name):
69+
"""Test that Gemma models are resolved correctly."""
70+
assert models.LLMRegistry.resolve(model_name) is Gemma
71+
72+
5973
@pytest.mark.parametrize(
6074
'model_name',
6175
[

0 commit comments

Comments
 (0)