refactor: remove input.type and output.type attributes from adk metrics

They were added prematurely, and currently output.type diverges from what's in semconv (https://opentelemetry.io/docs/specs/semconv/registry/attributes/gen-ai/), so this change removes them from our metrics, at least for the time being.

PiperOrigin-RevId: 910587563

Author: google-genai-bot

src/google/adk/flows/llm_flows/functions.py

@@ -593,7 +593,7 @@ async def _run_with_trace():
     return function_response_event
 
   async with _instrumentation.record_tool_execution(
-      tool, agent, invocation_context, function_args
+      tool, agent, function_args
   ) as tel_ctx:
     tel_ctx.function_response_event = await _run_with_trace()
     return tel_ctx.function_response_event
@@ -828,7 +828,7 @@ async def _run_with_trace():
     return function_response_event
 
   async with _instrumentation.record_tool_execution(
-      tool, agent, invocation_context, function_args
+      tool, agent, function_args
   ) as tel_ctx:
     tel_ctx.function_response_event = await _run_with_trace()
     return tel_ctx.function_response_event

src/google/adk/telemetry/_instrumentation.py

@@ -17,7 +17,6 @@
 import contextlib
 import dataclasses
 import logging
-import sys
 import time
 from typing import Any
 from typing import AsyncIterator
@@ -94,8 +93,6 @@ async def record_agent_invocation(
       _metrics.record_agent_invocation_duration(
           agent.name,
           elapsed_ms,
-          ctx.user_content,
-          ctx.session.events,
           caught_error,
       )
       _metrics.record_agent_request_size(agent.name, ctx.user_content)
@@ -111,14 +108,12 @@ async def record_agent_invocation(
 async def record_tool_execution(
     tool: BaseTool,
     agent: BaseAgent,
-    invocation_context: InvocationContext,
     function_args: dict[str, Any],
 ) -> AsyncIterator[TelemetryContext]:
   """Unified context manager for consolidated tool execution telemetry."""
   start_time = time.monotonic()
   caught_error: Exception | None = None
   span: trace.Span | None = None
-  tel_ctx: TelemetryContext | None = None
   span_name = f"execute_tool {tool.name}"
   try:
     with tracing.tracer.start_as_current_span(span_name) as s:
@@ -140,22 +135,11 @@ async def record_tool_execution(
             error=caught_error,
         )
   finally:
-    elapsed_ms = _get_elapsed_ms(span, start_time)
-    result_event = (
-        tel_ctx.function_response_event if tel_ctx is not None else None
-    )
-    output_content = (
-        result_event.content
-        if isinstance(result_event, event_lib.Event)
-        else None
-    )
     try:
       _metrics.record_tool_execution_duration(
           tool_name=tool.name,
           agent_name=agent.name,
-          elapsed_ms=elapsed_ms,
-          input_content=invocation_context.user_content,
-          output_content=output_content,
+          elapsed_ms=_get_elapsed_ms(span, start_time),
           error=caught_error,
       )
     except Exception:  # pylint: disable=broad-exception-caught

src/google/adk/telemetry/_metrics.py

@@ -27,7 +27,6 @@
 
 # TODO(b/477553411): add these attributes to Otel semconv.
 GEN_AI_AGENT_VERSION = "gen_ai.agent.version"
-GEN_AI_INPUT_TYPE = "gen_ai.input.type"
 GEN_AI_TOOL_VERSION = "gen_ai.tool.version"
 
 # Initialize meter
@@ -65,60 +64,37 @@
 )
 
 
-def record_agent_request_size(
-    agent_name: str, user_content: types.Content | None
-):
-  """Records the size of the agent request."""
-  size = _get_content_size(user_content)
-  attrs = {
-      gen_ai_attributes.GEN_AI_AGENT_NAME: agent_name,
-      GEN_AI_INPUT_TYPE: _get_modality_from_content(user_content),
-  }
-  _agent_request_size.record(size, attributes=attrs)
-
-
 def record_agent_invocation_duration(
     agent_name: str,
     elapsed_ms: float,
-    user_content: types.Content | None,
-    events: list[Event],
     error: Exception | None = None,
 ):
   """Records the duration of the agent invocation."""
-  response_content: types.Content | None = None
-  for event in reversed(events):
-    if event.author == agent_name and event.content:
-      response_content = event.content
-      break
-
-  attrs = {
-      gen_ai_attributes.GEN_AI_AGENT_NAME: agent_name,
-      GEN_AI_INPUT_TYPE: _get_modality_from_content(user_content),
-      gen_ai_attributes.GEN_AI_OUTPUT_TYPE: _get_modality_from_content(
-          response_content
-      ),
-  }
+  attrs = {gen_ai_attributes.GEN_AI_AGENT_NAME: agent_name}
   if error is not None:
     attrs[error_attributes.ERROR_TYPE] = type(error).__name__
   _agent_invocation_duration.record(elapsed_ms, attributes=attrs)
 
 
+def record_agent_request_size(
+    agent_name: str, user_content: types.Content | None
+):
+  """Records the size of the agent request."""
+  size = _get_content_size(user_content)
+  attrs = {gen_ai_attributes.GEN_AI_AGENT_NAME: agent_name}
+  _agent_request_size.record(size, attributes=attrs)
+
+
 def record_agent_response_size(agent_name: str, events: list[Event]):
   """Records the size of the agent response by extracting content from events."""
   response_content: types.Content | None = None
   for event in reversed(events):
-    # Need to look for author matching agent_name and having content
     if event.author == agent_name and event.content:
       response_content = event.content
       break
 
   size = _get_content_size(response_content)
-  attrs = {
-      gen_ai_attributes.GEN_AI_AGENT_NAME: agent_name,
-      gen_ai_attributes.GEN_AI_OUTPUT_TYPE: _get_modality_from_content(
-          response_content
-      ),
-  }
+  attrs = {gen_ai_attributes.GEN_AI_AGENT_NAME: agent_name}
   _agent_response_size.record(size, attributes=attrs)
 
 
@@ -134,52 +110,18 @@ def record_tool_execution_duration(
     tool_name: str,
     agent_name: str,
     elapsed_ms: float,
-    input_content: types.Content | None,
-    output_content: types.Content | None,
     error: Exception | None = None,
 ):
   """Records the duration of the tool execution."""
   attrs = {
       gen_ai_attributes.GEN_AI_AGENT_NAME: agent_name,
       gen_ai_attributes.GEN_AI_TOOL_NAME: tool_name,
-      GEN_AI_INPUT_TYPE: _get_modality_from_content(input_content),
   }
   if error is not None:
     attrs[error_attributes.ERROR_TYPE] = type(error).__name__
-  else:
-    attrs[gen_ai_attributes.GEN_AI_OUTPUT_TYPE] = _get_modality_from_content(
-        output_content
-    )
   _tool_execution_duration.record(elapsed_ms, attributes=attrs)
 
 
-# Helper functions copied from metrics_plugin.py
-
-
-def _get_modality_from_content(
-    content: types.Content | None,
-) -> str:
-  if content is None or not content.parts:
-    return "unknown"
-  modalities = set()
-  for part in content.parts:
-    if part.text is not None:
-      modalities.add("text")
-    inline_data = part.inline_data
-    if inline_data and inline_data.mime_type:
-      mime = inline_data.mime_type
-      if "/" in mime:
-        modalities.add(mime.split("/")[0])
-    file_data = part.file_data
-    if file_data and file_data.mime_type:
-      mime = file_data.mime_type
-      if "/" in mime:
-        modalities.add(mime.split("/")[0])
-  if not modalities:
-    return "text"
-  return ",".join(sorted(modalities))
-
-
 def _get_content_size(
     content: types.Content | None,
 ) -> int:

tests/unittests/telemetry/test_functional.py

@@ -316,8 +316,6 @@ async def generate_random_number():
       MetricPoint(
           attributes={
               "gen_ai.agent.name": "complex_agent",
-              "gen_ai.input.type": "text",
-              "gen_ai.output.type": "text",
           },
           value=None,
       )
@@ -334,17 +332,13 @@ async def generate_random_number():
           attributes={
               "gen_ai.agent.name": "complex_agent",
               "gen_ai.tool.name": "generate_random_number",
-              "gen_ai.input.type": "text",
-              "gen_ai.output.type": "text",
           },
           value=None,
       ),
       MetricPoint(
           attributes={
               "gen_ai.agent.name": "complex_agent",
               "gen_ai.tool.name": "get_current_time",
-              "gen_ai.input.type": "text",
-              "gen_ai.output.type": "text",
           },
           value=None,
       ),
@@ -401,7 +395,6 @@ async def failing_tool():
           attributes={
               "gen_ai.agent.name": "error_agent",
               "gen_ai.tool.name": "failing_tool",
-              "gen_ai.input.type": "text",
               "error.type": "ValueError",
           },
           value=None,
@@ -410,8 +403,6 @@ async def failing_tool():
           attributes={
               "gen_ai.agent.name": "error_agent",
               "gen_ai.tool.name": "get_current_time",
-              "gen_ai.input.type": "text",
-              "gen_ai.output.type": "text",
           },
           value=None,
       ),