Skip to content

Commit a8658f5

Browse files
committed
create an InMemoryMemoryService within the evaluation generator and passed it to the runner so that evaluation does not break when InMemoryMemoryService is used
1 parent 6191412 commit a8658f5

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

src/google/adk/evaluation/evaluation_generator.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,11 @@
2424
from ..agents.llm_agent import Agent
2525
from ..artifacts.base_artifact_service import BaseArtifactService
2626
from ..artifacts.in_memory_artifact_service import InMemoryArtifactService
27+
from ..memory import BaseMemoryService, InMemoryMemoryService
2728
from ..runners import Runner
2829
from ..sessions.base_session_service import BaseSessionService
2930
from ..sessions.in_memory_session_service import InMemorySessionService
31+
from ..memory.in_memory_memory_service import InMemoryMemoryService
3032
from ..sessions.session import Session
3133
from .eval_case import EvalCase
3234
from .eval_case import IntermediateData
@@ -142,11 +144,15 @@ async def _generate_inferences_from_root_agent(
142144
session_id: Optional[str] = None,
143145
session_service: Optional[BaseSessionService] = None,
144146
artifact_service: Optional[BaseArtifactService] = None,
147+
memory_service: Optional[BaseMemoryService] = None,
145148
) -> list[Invocation]:
146149
"""Scrapes the root agent given the list of Invocations."""
147150
if not session_service:
148151
session_service = InMemorySessionService()
149152

153+
if not memory_service:
154+
memory_service = InMemoryMemoryService()
155+
150156
app_name = (
151157
initial_session.app_name if initial_session else "EvaluationGenerator"
152158
)
@@ -168,6 +174,7 @@ async def _generate_inferences_from_root_agent(
168174
agent=root_agent,
169175
artifact_service=artifact_service,
170176
session_service=session_service,
177+
memory_service=memory_service,
171178
)
172179

173180
# Reset agent state for each query

0 commit comments

Comments
 (0)