Commit b2e2d7b
committed
docs: address Gemini Code Assist bot review feedback
- Update llm_response.py docstring to use 'underlying model providers'
instead of specifically 'LiteLLM' for better generalization
- Add explanatory comment for tool_calls->STOP mapping:
- FinishReason.TOOL_CALL enum does not exist in google-genai
- Tool calls are normal completion (STOP is semantically correct)
- Consistent with Gemini native behavior (lite_llm.py:910)
Addresses bot feedback:
- Make docstring more general about finish_reason sources
- Clarify why tool_calls maps to STOP (not a different enum)1 parent 83272ed commit b2e2d7b
2 files changed
Lines changed: 8 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
68 | 72 | | |
69 | 73 | | |
70 | 74 | | |
71 | | - | |
72 | | - | |
| 75 | + | |
| 76 | + | |
73 | 77 | | |
74 | 78 | | |
75 | 79 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
85 | | - | |
| 84 | + | |
| 85 | + | |
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
| |||
0 commit comments