fix: exclude scripts/ from pre-commit compliance checks

scripts/compliance_checks.py documents and matches the very patterns it
forbids, so the compliance-checks hook (which scanned every .py file)
flagged itself and failed on every PR running pre-commit on all files.
Skip the dev-only scripts/ directory. Also clears pre-existing pyink and
end-of-file drift surfaced by the same all-files run.

Co-authored-by: George Weale <gweale@google.com>
PiperOrigin-RevId: 940618068

Author: GWeale

.github/workflows/continuous-integration.yml

@@ -152,5 +152,3 @@ jobs:
             -n auto \
             --ignore=tests/unittests/artifacts/test_artifact_service.py \
             --ignore=tests/unittests/tools/google_api_tool/test_googleapi_to_openapi_converter.py
-
-

.pre-commit-config.yaml

@@ -61,6 +61,9 @@ repos:
         entry: scripts/compliance_checks.py
         language: script
         files: \.py$
+        # This script documents and matches the very patterns it forbids, so
+        # it must not scan itself or other dev-only tooling.
+        exclude: ^scripts/
   - repo: https://github.com/executablebooks/mdformat
     rev: 0.7.22
     hooks:

scripts/compliance_checks.py

@@ -87,7 +87,7 @@
 
 
 def check_logger(content: str) -> bool:
-  # Forbidden: 'logger = logging.getLogger(__name__)'
+  # Forbidden: getLogger(__name__) without the 'google_adk.' prefix.
   pattern = re.compile(r'logger\s*=\s*logging\.getLogger\(__name__\)')
   return not pattern.search(content)
 
@@ -142,14 +142,15 @@ def main() -> None:
       with open(f, 'r', encoding='utf-8') as file:
         content = file.read()
     except Exception as e:  # pylint: disable=broad-except
-      print(f"Error reading {f}: {e}")
+      print(f'Error reading {f}: {e}')
       continue
 
     # Run checks
     if not check_logger(content):
       print(
-          f"❌ {f}: Found forbidden use of 'logger = logging.getLogger(__name__)'. "
-          "Please use 'logger = logging.getLogger(\"google_adk.\" + __name__)' instead."
+          f"❌ {f}: Found forbidden use of 'logger ="
+          " logging.getLogger(__name__)'. Please use 'logger ="
+          ' logging.getLogger("google_adk." + __name__)\' instead.'
       )
       failed = True
 
@@ -159,13 +160,15 @@ def main() -> None:
 
     if not check_cli_import(content, f):
       print(
-          f"❌ {f}: Do not import from the cli package outside of the cli package."
+          f'❌ {f}: Do not import from the cli package outside of the cli'
+          ' package.'
       )
       failed = True
 
     if not check_mtls(content, f):
       print(
-          f"❌ {f}: Found hardcoded googleapis.com endpoints without mTLS support."
+          f'❌ {f}: Found hardcoded googleapis.com endpoints without mTLS'
+          ' support.'
       )
       failed = True