Commit d8f93b3
committed
test(models): re-enable finish_reason unknown-maps-to-OTHER litellm test
test_finish_reason_unknown_maps_to_other was skipped during the v2.0.0 GA
transition with reason "LiteLLM finish_reason mapping behaviour changed".
That reason is now stale: _map_finish_reason ends with
_FINISH_REASON_MAPPING.get(finish_reason_str, types.FinishReason.OTHER), so
any unmapped finish_reason deterministically maps to OTHER regardless of
LiteLLM's own normalization. The test bypasses that normalization with a mock
returning a raw "totally_unknown_reason" and asserts the OTHER fallback.
This skipped test is the only coverage of the _map_finish_reason -> OTHER
fallback branch in the litellm suite, so the skip left a live production
branch untested. Removing the skip restores that coverage with no production
change; the test passes as-is.1 parent e6df097 commit d8f93b3
1 file changed
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4984 | 4984 | | |
4985 | 4985 | | |
4986 | 4986 | | |
4987 | | - | |
4988 | 4987 | | |
4989 | 4988 | | |
4990 | 4989 | | |
| |||
0 commit comments