Skip to content

Commit de0cfe0

Browse files
committed
fix: decode shell skill output as UTF-8
1 parent e6df097 commit de0cfe0

2 files changed

Lines changed: 3 additions & 0 deletions

File tree

src/google/adk/tools/skill_toolset.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -745,6 +745,7 @@ def _build_wrapper_code(
745745
" _r = subprocess.run(",
746746
f" {arr!r},",
747747
" capture_output=True, text=True,",
748+
" encoding='utf-8', errors='replace',",
748749
f" timeout={timeout!r}, cwd=td,",
749750
" )",
750751
" print(_json.dumps({",

tests/unittests/tools/test_skill_toolset.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -996,6 +996,8 @@ async def test_execute_script_shell_success(mock_skill1):
996996
code_input = call_args[0][1]
997997
assert "subprocess.run" in code_input.code
998998
assert "bash" in code_input.code
999+
assert "encoding='utf-8'" in code_input.code
1000+
assert "errors='replace'" in code_input.code
9991001
assert "__shell_result__" in code_input.code
10001002

10011003

0 commit comments

Comments
 (0)