Skip to content

Commit e7cfd1c

Browse files
committed
fix(sessions): return empty events when num_recent_events=0 in DatabaseSessionService
1 parent 7c71626 commit e7cfd1c

2 files changed

Lines changed: 8 additions & 1 deletion

File tree

src/google/adk/sessions/database_session_service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -520,7 +520,7 @@ async def get_session(
520520

521521
stmt = stmt.order_by(schema.StorageEvent.timestamp.desc())
522522

523-
if config and config.num_recent_events:
523+
if config and config.num_recent_events is not None:
524524
stmt = stmt.limit(config.num_recent_events)
525525

526526
result = await sql_session.execute(stmt)

tests/unittests/sessions/test_session_service.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1057,6 +1057,13 @@ async def test_get_session_with_config(session_service):
10571057
events = session.events
10581058
assert len(events) == num_test_events
10591059

1060+
# num_recent_events=0 should return no events.
1061+
config = GetSessionConfig(num_recent_events=0)
1062+
session = await session_service.get_session(
1063+
app_name=app_name, user_id=user_id, session_id=session.id, config=config
1064+
)
1065+
assert len(session.events) == 0
1066+
10601067
# Only expect the most recent 3 events.
10611068
num_recent_events = 3
10621069
config = GetSessionConfig(num_recent_events=num_recent_events)

0 commit comments

Comments
 (0)