fix: correct triage agent paths#5757
Conversation
|
Response from ADK Triaging Agent Hello @fancydirty, thank you for creating this PR! This PR is a bug fix. To align fully with our contribution guidelines, could you please:
This information will help reviewers to review your PR more efficiently. Thanks! |
|
Hi @fancydirty , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Can you please fix the failing unit tests before we can proceed with the review. |
|
Hi @rohityan, thanks for the review. I updated the PR description to include a dedicated testing plan section and local verification output for the corrected PYTHONPATH/module resolution. I also refreshed the branch checks after the old failed run; current PR checks are green on my side. |
|
Hi @rohityan, I noticed this PR was closed after main was merged into the branch and the diff became empty. From what I can see, the same issues fixed by this PR are now resolved on main:
Could you clarify whether this PR was closed because the fix landed separately in main? If so, it would be helpful to note that here for the record, since this PR identified and proposed the same fixes earlier. Thanks. |
Summary
Fixes import paths for the ADK issue and pull request triaging workflows.
The workflows previously set PYTHONPATH to contributing/samples, but both packages live under contributing/samples/adk_team:
As a result, the PR triage job could fail before it could run:
This PR changes both triage workflows to use PYTHONPATH=contributing/samples/adk_team.
It also fixes the PR triaging agent CONTRIBUTING.md lookup. The previous parents[3] path resolved to contributing/CONTRIBUTING.md, but the file is in the repository root, so the correct path is parents[4] / CONTRIBUTING.md.
testing plan
Verified locally with corrected PYTHONPATH and dummy workflow environment variables in the Python 3.10 uv test environment.
Command summary:
Verification output: