fix: serialize non-standard FunctionResponse dicts in AnthropicLlm#4997
Closed
giulio-leone wants to merge 2 commits intogoogle:mainfrom
Closed
fix: serialize non-standard FunctionResponse dicts in AnthropicLlm#4997giulio-leone wants to merge 2 commits intogoogle:mainfrom
giulio-leone wants to merge 2 commits intogoogle:mainfrom
Conversation
Rebased onto latest main, resolved conflicts with upstream json.dumps improvement. Keeps both upstream's json.dumps serialization for standard results AND the fallback path for non-standard response dicts (e.g. SkillToolset).
Move the non-standard FunctionResponse assertions back into the regression test that exercises the fallback serialization path, and keep the PDF document test focused on document serialization only. Validated with pyink --check, the full anthropic_llm test file, and a runtime proof script covering both the fallback tool_result path and the PDF document path.
giulio-leone
force-pushed
the
fix/anthropic-function-response-fallback
branch
from
bc87808 to
5ad3427
Compare
Collaborator
|
Hi @giulio-leone, Thank you for your contribution! We appreciate you taking the time to submit this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4779
part_to_message_block()only handledfunction_responsedicts containing"content"or"result"keys. Any other dict structure (e.g. SkillToolset returning{"skill_name": ..., "instructions": ...}) fell through to an empty string, causing Claude to never see the tool output.Changes
anthropic_llm.py: Addedjson.dumps()fallback after the existing"content"/"result"checks, so non-standard response dicts are serialized to JSON text instead of being silently dropped.test_anthropic_llm.py: Added regression test verifying that a SkillToolset-style response dict is round-tripped correctly throughpart_to_message_block().Testing
test_anthropic_llm.pytests pass (including the new one)