You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
During agent invocation, OAuth redirection happens for every toolset (that returns an AuthConfig) regardless of whether the user message requires tool invocation or not.
Solution
This PR defers the OAuth flow to tool invocation time, which already works as expected.
I have commented my code, particularly in hard-to-understand areas.
I have added tests that prove my fix is effective or that my feature works.
New and existing unit tests pass locally with my changes.
I have manually tested my changes end-to-end.
Any dependent changes have been merged and published in downstream modules.
Additional context
Since _resolve_toolset_auth() will simply defer auth flows to tool invocation time, there is no need to handle the topic of framework- and tool-level credential file path mismatch in this PR. Once consensus is reached, a separate PR can be opened for it later.
adk-bot
added
the
core
[Component] This issue is related to the core interface and implementation
label
Apr 16, 2026
patrasap0908
changed the title
fix (auth): remove unneeded oauth flows
fix(auth): remove unneeded OAuth flows
Apr 16, 2026
Hi @patrasap0908 , Thank you for your contribution through this pull request! This PR has merge conflicts that require changes from your end. Could you please rebase your branch with the latest main branch to address these? Once this is complete, please let us know so we can proceed with the review.
Hi @patrasap0908 , Thank you for your contribution through this pull request! This PR has merge conflicts that require changes from your end. Could you please rebase your branch with the latest main branch to address these? Once this is complete, please let us know so we can proceed with the review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core[Component] This issue is related to the core interface and implementationrequest clarification[Status] The maintainer need clarification or more information from the author
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Problem
During agent invocation, OAuth redirection happens for every toolset (that returns an
AuthConfig) regardless of whether the user message requires tool invocation or not.Solution
This PR defers the OAuth flow to tool invocation time, which already works as expected.
Testing plan
Unit tests
End-to-end test results:
Checklist
Additional context
Since
_resolve_toolset_auth()will simply defer auth flows to tool invocation time, there is no need to handle the topic of framework- and tool-level credential file path mismatch in this PR. Once consensus is reached, a separate PR can be opened for it later.