Fix: InMemoryMemoryService search with non-Latin text#5508
Closed
9chait9 wants to merge 1 commit into
Closed
Conversation
adk-bot
added
the
services
Collaborator
|
Response from ADK Triaging Agent Hello @9chait9, thank you for creating this PR! To help reviewers to review your PR more efficiently, could you please include a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5501
This PR addresses issue #5501 by modifying the _extract_words_lower function in src/google/adk/memory/in_memory_memory_service.py. The regular expression used for word extraction has been updated from r'[A-Za-z]+' to r'\w+' with the re.UNICODE flag, enabling correct recognition and extraction of words from non-Latin scripts (e.g., Japanese, Chinese, Korean). This ensures that InMemoryMemoryService.search_memory can now accurately search for and retrieve content in these languages.