Skip to content

Avoid Firestore-reserved session metadata key in ADK Web UI#5540

Closed
kkj333 wants to merge 1 commit into
google:mainfrom
kkj333:fix/web-ui-firestore-session-metadata
Closed

Avoid Firestore-reserved session metadata key in ADK Web UI#5540
kkj333 wants to merge 1 commit into
google:mainfrom
kkj333:fix/web-ui-firestore-session-metadata

Conversation

@kkj333
Copy link
Copy Markdown

@kkj333 kkj333 commented Apr 29, 2026

Summary

  • Rename the ADK Web UI's internal session metadata state key from __session_metadata__ to adk_session_metadata for new writes.
  • Preserve backwards-compatible display-name reads by checking adk_session_metadata first and falling back to __session_metadata__.

Test plan

  • node --check src/google/adk/cli/browser/main-TCIQIOZ3.js
  • Targeted string checks confirmed no creation object, state delta, or create-session payload writes __session_metadata__.

Related to #5539

Made with Cursor

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Apr 29, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@adk-bot adk-bot added the web [Component] This issue will be transferred to adk-web label Apr 29, 2026
@adk-bot
Copy link
Copy Markdown
Collaborator

adk-bot commented Apr 29, 2026

Response from ADK Triaging Agent

Hello @kkj333, thank you for your contribution!

Before we can merge this pull request, you'll need to sign the Contributor License Agreement (CLA). It seems that the cla/google check is currently failing. You can find more information and sign the CLA at https://cla.developers.google.com/.

Once you've signed the CLA, the status check will be updated, and we can proceed with the review.

Thanks!

@kkj333
Copy link
Copy Markdown
Author

kkj333 commented Apr 29, 2026

Closing this for now. The issue is likely best fixed in the ADK Web source repository and then propagated into this bundled asset. I will wait for maintainer guidance on #5539 before opening another PR.

@kkj333 kkj333 closed this Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

web [Component] This issue will be transferred to adk-web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants