-
Notifications
You must be signed in to change notification settings - Fork 3.7k
feat(eval): expose user_simulator_config in generate_responses #5733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
primenko-v
wants to merge
15
commits into
google:main
from
primenko-v:propagate-user-simulator-config
Closed
Changes from 10 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ffc4361
Configure UserSimulatorProvider
primenko-v e5892f8
Merge 'main' into propagate-user-simulator-config
primenko-v caf69f2
Test UserSimulatorProvider configuration
primenko-v 780a640
Add docstring for user_simulator_config param
primenko-v 6945d43
Merge branch 'main' into propagate-user-simulator-config
primenko-v 2301b07
Remove the stale evaluation_generator comment
primenko-v c50bc32
Merge branch 'main' into propagate-user-simulator-config
rohityan 9a4526f
Merge branch 'main' into propagate-user-simulator-config
rohityan 1248a64
Fix formatting
primenko-v 17e6dfb
Merge branch 'main' into propagate-user-simulator-config
rohityan 109a0fd
Merge 'main' into propagate-user-simulator-config
primenko-v ad00b9b
Clean up test_evaluation_generator
primenko-v 942b263
Add back TestGenerateResponses
primenko-v dcfbbe1
Merge branch 'main' into propagate-user-simulator-config
primenko-v 24209b6
Merge branch 'google:main' into propagate-user-simulator-config
primenko-v File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this new class. The newly added test case can be a part of the existing class
TestGenerateInferencesFromRootAgentThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the feedback @ankursharmas !
The newly added test exercises
generate_responsesrather than_generate_inferences_from_root_agent. It seems to me thattest_evaluation_generator.pymostly follows a one-class-per-method convention, where each test class targets a single method. For example:TestConvertEventsToEvalInvocationconvert_events_to_eval_invocationsTestGetAppDetailsByInvocationId_get_app_details_by_invocation_idTestGenerateInferencesForSingleUserInvocation_generate_inferences_for_single_user_invocationTestGenerateInferencesForSingleUserInvocationLive_generate_inferences_for_single_user_invocation_liveFollowing that, wouldn't a separate
TestGenerateResponsesclass forgenerate_responsesfit better here?While looking at this I also noticed that
test_generates_inferences_with_user_simulator_livelives inTestGenerateInferencesFromRootAgenteven though it tests_generate_inferences_from_root_agent_live, so the convention is already a bit mixed there.On a separate note: there was a careless merge on my side which I have now fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah makes sense! Thank you for pointing that out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ankursharmas do you consider the conversation resolved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ankursharmas this PR is currently blocked by this open thread. Let me know if you need any further changes from my side; otherwise, could you please resolve the conversation?