Skip to content

Check hardcode linter#5775

Open
agrawalradhika-cell wants to merge 3 commits into
google:mainfrom
agrawalradhika-cell:check-hardcode-linter
Open

Check hardcode linter#5775
agrawalradhika-cell wants to merge 3 commits into
google:mainfrom
agrawalradhika-cell:check-hardcode-linter

Conversation

@agrawalradhika-cell
Copy link
Copy Markdown

Please ensure you have read the contribution guide before creating a pull request.

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

  • Closes: #issue_number
  • Related: #issue_number

2. Or, if no issue exists, describe the change:

If applicable, please follow the issue templates to provide as much detail as
possible.

Problem:
A clear and concise description of what the problem is.

Solution:
A clear and concise description of what you want to happen and why you choose
this solution.

Testing Plan

Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

Please include a summary of passed pytest results.

Manual End-to-End (E2E) Tests:

Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

Additional context

Add any other context or screenshots about the feature request here.

…endpoints

feat: Update check-file-contents.yml to check for non-mTLS hardcoded endpoints
chore: test hardcoded linter Update agent.py
@adk-bot
Copy link
Copy Markdown
Collaborator

adk-bot commented May 20, 2026

Response from ADK Triaging Agent

Hello @agrawalradhika-cell, thank you for creating this pull request!

It looks like this PR is currently not fully following our contribution guidelines. Could you please update your PR description to address the following:

  1. Issue or Description of Change: Please associate an existing GitHub issue or fill out the Problem and Solution sections in the template to describe the changes you are introducing.
  2. Testing Plan: Please fill out the testing plan section to describe how you tested this change (e.g., how the new workflow step in check-file-contents.yml was verified).
  3. Checklist: Please review and check off the applicable items in the PR checklist.

These details will help reviewers understand and review your PR much more efficiently. Thank you!

@rohityan rohityan self-assigned this May 20, 2026
@rohityan rohityan added the request clarification [Status] The maintainer need clarification or more information from the author label May 20, 2026
@rohityan
Copy link
Copy Markdown
Collaborator

Hi @agrawalradhika-cell , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Can you please add a description of what you are fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

request clarification [Status] The maintainer need clarification or more information from the author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants