fix(tools): hide skill script tool when no scripts exist#6300
Open
Oxygen56 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
Problem:
SkillToolsetalways exposedrun_skill_script, even when the configured local skills had no scripts. That gives the model an unavailable action surface and can contribute to repeated failed script calls.Solution:
Only register
RunSkillScriptToolwhen at least one local skill exposes scripts. Registry-backed toolsets keep the previous behavior because remote skill contents are not known at initialization time.Testing Plan
Unit Tests:
Passed locally:
Manual End-to-End (E2E) Tests:
Not run. The change is covered by isolated unit tests for the tool list returned by
SkillToolset.Checklist
Additional context
This keeps the script execution tool out of the model-visible tool list when there is no local script to run, while preserving registry behavior for dynamically loaded remote skills.