docs: fix "incase" typo in connection schema host description#6304
Open
anxkhn wants to merge 1 commit into
Open
docs: fix "incase" typo in connection schema host description#6304anxkhn wants to merge 1 commit into
anxkhn wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
2. Or, if no issue exists, describe the change:
Problem:
The
hostfield in the application integration connection config schema has atypo in its
descriptionstring: "Host name incase of tls service directory"."incase" should be two words, "in case". This description is surfaced to users
and models as part of the connector configuration schema, so the wording is
user-facing.
Solution:
Correct the single misspelled word: "incase" -> "in case", in
src/google/adk/tools/application_integration_tool/clients/connections_client.py.This is a string-literal-only change to the schema description text. There is no
behavior change: the string is a
descriptionvalue, not a lookup key, so nocode path or assertion depends on it.
"host": { "type": "string", "default": "", - "description": "Host name incase of tls service directory", + "description": "Host name in case of tls service directory", },Testing Plan
This is a small typo fix (documentation-only string literal), so a dedicated unit
test is not applicable: no test asserts on this string, and there is no code path
to exercise. For safety I still ran the existing suite and the formatters:
Unit Tests:
pre-commit(isort, pyink, addlicense, ruff, mdformat, header checks) passes onthe changed file.
Checklist
Additional context
Repo-wide there are no other occurrences of "incase"; this was the only instance.
Ship steps (for later, only after Anas approves via loop.sh ship)
gh repo fork google/adk-python.docs/connections-incase-typo(commit b606efa0) tothe fork.
anxkhn:docs/connections-incase-typointogoogle/adk-python:mainwith the title and body above.
(telemetry) does not touch this file, so the rebase at ship time is trivial and
conflict-free. Rebase onto latest origin/main immediately before pushing.
-ssign-off (repo uses Google CLA, not DCO). Anas's Google CLA must besigned/valid for the PR to pass the CLA check.