Skip to content

Commit 0173731

Browse files
committed
Fix the gpu mode ordering in the non-opt'ing path
#2611 was incorrect. The previous behavior was to prefer `--gpu_mode=gfxstream` over `--gpu_mode=guest_swiftshader` prior to the Jolt changes. Bug: b/513229182
1 parent ecba083 commit 0173731

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

base/cvd/cuttlefish/host/commands/assemble_cvd/graphics_flags.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -456,8 +456,8 @@ std::vector<GpuMode> GetGpuModeCandidates(const GuestConfig& guest_config) {
456456
gpu_mode_candidates.push_back(GpuMode::GfxstreamGuestAngleHostLavapipe);
457457
gpu_mode_candidates.push_back(GpuMode::GuestSwiftshader);
458458
} else {
459-
gpu_mode_candidates.push_back(GpuMode::GuestSwiftshader);
460459
gpu_mode_candidates.push_back(GpuMode::Gfxstream);
460+
gpu_mode_candidates.push_back(GpuMode::GuestSwiftshader);
461461
gpu_mode_candidates.push_back(GpuMode::GfxstreamGuestAngle);
462462
gpu_mode_candidates.push_back(GpuMode::GfxstreamGuestAngleHostSwiftshader);
463463
gpu_mode_candidates.push_back(GpuMode::GfxstreamGuestAngleHostLavapipe);

e2etests/cvd/graphics_detector_tests/main_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,15 @@ func TestLaunchingWithAutoEnablesGfxstream(t *testing.T) {
4444
if err != nil {
4545
t.Fatalf("failed to get EGL sysprop: %w", err)
4646
}
47-
if gl_driver != "angle" {
48-
t.Errorf(`"ro.hardware.egl" was "%s"; expected "angle"`, gl_driver)
47+
if gl_driver != "emulation" {
48+
t.Errorf(`"ro.hardware.egl" was "%s"; expected "emulation"`, gl_driver)
4949
}
5050

5151
vk_driver, err := c.GetSyspropString("ro.hardware.vulkan")
5252
if err != nil {
5353
t.Fatalf("failed to get Vulkan sysprop: %w", err)
5454
}
55-
if vk_driver != "pastel" {
56-
t.Errorf(`"ro.hardware.vulkan" was "%s"; expected "pastel"`, vk_driver)
55+
if vk_driver != "ranchu" {
56+
t.Errorf(`"ro.hardware.vulkan" was "%s"; expected "ranchu"`, vk_driver)
5757
}
5858
}

0 commit comments

Comments
 (0)