Skip to content

Commit 973c145

Browse files
committed
Do not launch WebRtcServer when GpuMode::None
When instance.gpu_mode() is GpuMode::None (headless mode), ScreenConnector explicitly rejects initialization and aborts process execution with: LOG(FATAL) << "Invalid gpu mode: none". Commit 63c9518 ("Remove the start_webrtc flag behavior") inadvertently caused WebRtcServer to launch even when `start_webrtc` is explicitly set to `false` on sdv_core targets. To fix this issue, let's skip enabling WebRtcServer whenever instance_.gpu_mode() == GpuMode::None. Bug: b/532203075
1 parent 7159dab commit 973c145

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

  • base/cvd/cuttlefish/host/commands/run_cvd/launch

base/cvd/cuttlefish/host/commands/run_cvd/launch/streamer.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ class WebRtcServer : public virtual CommandSource,
265265

266266
// SetupFeature
267267
bool Enabled() const override {
268-
return sockets_.Enabled() &&
268+
return sockets_.Enabled() && instance_.gpu_mode() != GpuMode::None &&
269269
(VmManagerIsCrosvm(config_) || VmManagerIsQemu(config_));
270270
}
271271

0 commit comments

Comments
 (0)