Request higher SafeLevel builds when requesting Android build by branch#2667
Merged
Conversation
cjreynol
reviewed
Jun 5, 2026
Databean
force-pushed
the
request-higher-safe-level
branch
2 times, most recently
from
f0cdf05 to
f077e54
Compare
Databean
commented
Jun 5, 2026
Databean
left a comment
Databean
left a comment
Member
Author
There was a problem hiding this comment.
Thanks for reviewing!
Databean
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
cjreynol
approved these changes
Jun 8, 2026
Databean
force-pushed
the
request-higher-safe-level
branch
from
f077e54 to
4acbd48
Compare
Member
Author
|
Thanks for reviewing! |
Databean
force-pushed
the
request-higher-safe-level
branch
from
4acbd48 to
b8b5ae2
Compare
In cvd fetch, when requesting a build by branch and target, prefer requesting higher SafeLevel builds (PLATINUM, SAFE_2, SAFE_1) when possible before falling back to any complete successful build (SAFE_0 / unspecified). If users want a specific build id, that is already possible to request through command line arguments. When a user requests a branch by name, they probably do not care as much how recent the build is. In the case of our presubmit, this will hopefully reduce flakes that come from the device side. The main failure mode here is if a build target / branch combination has previously reported a higher safe level and no longer does, it will get stuck on the older build from the higher safe level indefinitely. Assisted-by: Jetski:Gemini Next Bug: b/518049553
Databean
force-pushed
the
request-higher-safe-level
branch
from
b8b5ae2 to
c322256
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cvd fetch, when requesting a build by branch and target, prefer requesting higher SafeLevel builds (PLATINUM, SAFE_2, SAFE_1) when possible before falling back to any complete successful build (SAFE_0 / unspecified).
If users want a specific build id, that is already possible to request through command line arguments. When a user requests a branch by name, they probably do not care as much how recent the build is. In the case of our presubmit, this will hopefully reduce flakes that come from the device side.
The main failure mode here is if a build target / branch combination has previously reported a higher safe level and no longer does, it will get stuck on the older build from the higher safe level indefinitely.
Assisted-by: Jetski:Gemini Next
Bug: b/518049553