Update cvd monitor to use inotify#2692
Merged
Merged
Conversation
jemoreira
reviewed
Jun 11, 2026
This replaces the 50ms polling loop with an event-driven approach using inotify to wait for log file changes. It implements stack-based, non-blocking event coalescing and a 20 FPS rate-limiting throttle to protect terminal bandwidth and CPU during log storms. Additionally, this adds InotifyAddWatch retries on every frame if watches fail or log files are missing, refactors the retrying logic into a reusable mutating helper function, supervises the loop with SharedFD::Poll() and a single unified drain read using a dynamic 1-second fallback timeout, supervises read operations with CF_EXPECT / CF_EXPECTF to catch unexpected errors, and eliminates initial frame throttling delays by starting with a 0 epoch draw time. Assisted-by: Jetski:Gemini Next
Databean
force-pushed
the
update-monitor-inotify
branch
from
0e4f9fc to
52e1551
Compare
Member
Author
|
Thanks for reviewing! |
jemoreira
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the 50ms polling loop with an event-driven approach using inotify to wait for log file changes, implementing FIONREAD event coalescing and a 20 FPS rate-limiting throttle to protect terminal bandwidth during log storms.
Assisted-by: Jetski:Gemini Next