Refactor DownloadFileWithBackup to a freestanding function#2695
Merged
rmuthiah merged 1 commit intoJun 12, 2026
Conversation
- Remove DownloadFileWithBackup from BuildApi interface. - Implement it as a freestanding function accepting BuildApi& in build_api.cpp. - Remove implementations from AndroidBuildApi and CachingBuildApi. - Add unit tests for the new freestanding function. Assisted-by: Jetski:Gemini Next
Databean
force-pushed
the
refactor-download-file-with-backup
branch
from
7bfdfc1 to
4a9577f
Compare
jemoreira
approved these changes
Jun 11, 2026
Member
Author
|
Thanks for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the BuildApi interface smaller, reducing the burden on interface implementations. The extracted logic is also now shared between all implementations.
Assisted-by: Jetski:Gemini Next