Do not launch WebRtcServer for GpuMode::None#2820
Merged
Merged
Conversation
When instance.gpu_mode() is GpuMode::None (headless mode), ScreenConnector explicitly rejects initialization and aborts process execution with: LOG(FATAL) << "Invalid gpu mode: none". Commit 63c9518 ("Remove the start_webrtc flag behavior") inadvertently caused WebRtcServer to launch even when `start_webrtc` is explicitly set to `false` on sdv_core targets. To fix this issue, let's skip enabling WebRtcServer whenever instance_.gpu_mode() == GpuMode::None. Bug: b/532203075
Databean
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When instance.gpu_mode() is GpuMode::None (headless mode), ScreenConnector explicitly rejects initialization and aborts process execution with: LOG(FATAL) << "Invalid gpu mode: none".
Commit 63c9518 ("Remove the start_webrtc flag behavior") inadvertently caused WebRtcServer to launch even when
start_webrtcis explicitly set tofalseon sdv_core targets. To fix this issue, let's skip enabling WebRtcServer whenever instance_.gpu_mode() == GpuMode::None.Bug: b/532203075