Attempt suppressing a trace on boot failure.#2824
Open
3405691582 wants to merge 1 commit into
Open
Conversation
When a boot fails, we print a trace saying that run_cvd failed. This isn't strictly necessary or informative, so attempt to suppress this by just returning a CF_ERR instead of CF_EXPECT'ing that the executable returned successfully -- because we already know it didn't.
Collaborator
Author
|
I'm not sure if this will have the intended effect, because I'm not sure how to trigger this myself, but I'm assuming you'd have a slightly better idea here than I would. |
Member
|
I cherry-picked this change and additionally changed This PR cuts a level off the stack trace, but ultimately still produces the stack trace, which is still relatively noisy. |
Member
|
I've uploaded https://www.github.com/google/android-cuttlefish/pull/2826 to hide the stack traces created by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a boot fails, we print a trace saying that run_cvd failed. This isn't strictly necessary or informative, so attempt to suppress this by just returning a CF_ERR instead of CF_EXPECT'ing that the executable returned successfully -- because we already know it didn't.