Clear the source position for only the dangling macro expr ID instead of all exprs

PiperOrigin-RevId: 632228017

Author: l46kok

common/src/main/java/dev/cel/common/CelSource.java

@@ -261,12 +261,6 @@ public Builder addPositions(long exprId, int position) {
       return this;
     }
 
-    @CanIgnoreReturnValue
-    public Builder clearPositions() {
-      this.positions.clear();
-      return this;
-    }
-
     @CanIgnoreReturnValue
     public Builder removePositions(long exprId) {
       this.positions.remove(exprId);

parser/src/main/java/dev/cel/parser/Parser.java

@@ -896,7 +896,7 @@ private CelExpr macroOrCall(
     ImmutableList<CelExpr> arguments = visitExprListContext(args);
     Optional<CelExpr> errorArg = arguments.stream().filter(ERROR::equals).findAny();
     if (errorArg.isPresent()) {
-      sourceInfo.clearPositions();
+      sourceInfo.removePositions(exprBuilder.id());
       // Any arguments passed in to the macro may fail parsing.
       // Stop the macro expansion in this case as the result of the macro will be a parse failure.
       return ERROR;

parser/src/test/java/dev/cel/parser/CelParserParameterizedTest.java

@@ -239,6 +239,7 @@ public void parser_errors() {
     runTest(PARSER, "TestAllTypes(){single_int32: 1, single_int64: 2}");
     runTest(PARSER, "{");
     runTest(PARSER, "t{>C}");
+    runTest(PARSER, "has([(has((");
 
     CelParser parserWithoutOptionalSupport =
         CelParserImpl.newBuilder()

parser/src/test/resources/parser_errors.baseline

@@ -262,6 +262,15 @@ ERROR: <input>:1:5: mismatched input '}' expecting ':'
  | t{>C}
  | ....^
 
+I: has([(has((
+=====>
+E: ERROR: <input>:1:4: invalid argument to has() macro
+ | has([(has((
+ | ...^
+ERROR: <input>:1:12: mismatched input '<EOF>' expecting {'[', '{', '(', '.', '-', '!', 'true', 'false', 'null', NUM_FLOAT, NUM_INT, NUM_UINT, STRING, BYTES, IDENTIFIER}
+ | has([(has((
+ | ...........^
+
 I: a.?b && a[?b]
 =====>
 E: ERROR: <input>:1:2: unsupported syntax '.?'
@@ -287,4 +296,4 @@ E: ERROR: <input>:1:2: unsupported syntax '?'
  | .^
 ERROR: <input>:1:6: unsupported syntax '?'
  | [?a, ?b]
- | .....^
+ | .....^