Skip to content

Commit 7f93040

Browse files
committed
Remove mutablelist for now
1 parent a599d6d commit 7f93040

3 files changed

Lines changed: 17 additions & 117 deletions

File tree

common/src/main/java/dev/cel/common/values/BUILD.bazel

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -157,28 +157,6 @@ cel_android_library(
157157
],
158158
)
159159

160-
java_library(
161-
name = "mutable_list_value",
162-
srcs = ["MutableListValue.java"],
163-
tags = [
164-
],
165-
deps = [
166-
":cel_byte_string",
167-
":cel_value",
168-
":values",
169-
"//:auto_value",
170-
"//common:error_codes",
171-
"//common:runtime_exception",
172-
"//common/annotations",
173-
"//common/types",
174-
"//common/types:type_providers",
175-
"@maven//:com_google_errorprone_error_prone_annotations",
176-
"@maven//:com_google_guava_guava",
177-
"@maven//:com_google_protobuf_protobuf_java",
178-
"@maven//:org_jspecify_jspecify",
179-
],
180-
)
181-
182160
java_library(
183161
name = "cel_byte_string",
184162
srcs = ["CelByteString.java"],

common/src/main/java/dev/cel/common/values/MutableListValue.java

Lines changed: 0 additions & 78 deletions
This file was deleted.

runtime/src/test/java/dev/cel/runtime/planner/ProgramPlannerTest.java

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -470,10 +470,10 @@ public void planSelect() throws Exception {
470470
}
471471

472472
@Test
473-
// @TestParameters("{expression: '[1,2,3].exists(x, x > 0) == true'}")
474-
// @TestParameters("{expression: '[1,2,3].exists(x, x < 0) == false'}")
475-
// @TestParameters("{expression: '[1,2,3].exists(i, v, i >= 0 && v > 0) == true'}")
476-
// @TestParameters("{expression: '[1,2,3].exists(i, v, i < 0 || v < 0) == false'}")
473+
@TestParameters("{expression: '[1,2,3].exists(x, x > 0) == true'}")
474+
@TestParameters("{expression: '[1,2,3].exists(x, x < 0) == false'}")
475+
@TestParameters("{expression: '[1,2,3].exists(i, v, i >= 0 && v > 0) == true'}")
476+
@TestParameters("{expression: '[1,2,3].exists(i, v, i < 0 || v < 0) == false'}")
477477
@TestParameters("{expression: '[1,2,3].map(x, x + 1) == [2,3,4]'}")
478478
public void planComprehension_lists(String expression) throws Exception {
479479
CelAbstractSyntaxTree ast = compile(expression);
@@ -484,19 +484,19 @@ public void planComprehension_lists(String expression) throws Exception {
484484
assertThat(result).isTrue();
485485
}
486486

487-
// @Test
488-
// @TestParameters("{expression: '[1,2,3].exists(x, x > 0) == true'}")
489-
// @TestParameters("{expression: '[1,2,3].exists(x, x < 0) == false'}")
490-
// @TestParameters("{expression: '[1,2,3].exists(i, v, i >= 0 && v > 0) == true'}")
491-
// @TestParameters("{expression: '[1,2,3].exists(i, v, i < 0 || v < 0) == false'}")
492-
// public void planComprehension_maps(String expression) throws Exception {
493-
// CelAbstractSyntaxTree ast = compile(expression);
494-
// Program program = PLANNER.plan(ast);
495-
//
496-
// boolean result = (boolean) program.eval();
497-
//
498-
// assertThat(result).isTrue();
499-
// }
487+
@Test
488+
@TestParameters("{expression: '[1,2,3].exists(x, x > 0) == true'}")
489+
@TestParameters("{expression: '[1,2,3].exists(x, x < 0) == false'}")
490+
@TestParameters("{expression: '[1,2,3].exists(i, v, i >= 0 && v > 0) == true'}")
491+
@TestParameters("{expression: '[1,2,3].exists(i, v, i < 0 || v < 0) == false'}")
492+
public void planComprehension_maps(String expression) throws Exception {
493+
CelAbstractSyntaxTree ast = compile(expression);
494+
Program program = PLANNER.plan(ast);
495+
496+
boolean result = (boolean) program.eval();
497+
498+
assertThat(result).isTrue();
499+
}
500500

501501
private CelAbstractSyntaxTree compile(String expression) throws Exception {
502502
CelAbstractSyntaxTree ast = CEL_COMPILER.parse(expression).getAst();

0 commit comments

Comments
 (0)