Plan create list

Author: l46kok

runtime/src/main/java/dev/cel/runtime/planner/BUILD.bazel

@@ -17,6 +17,7 @@ java_library(
         ":eval_and",
         ":eval_attribute",
         ":eval_const",
+        ":eval_create_list",
         ":eval_create_map",
         ":eval_create_struct",
         ":eval_or",
@@ -217,6 +218,22 @@ java_library(
     ],
 )
 
+java_library(
+    name = "eval_create_list",
+    srcs = ["EvalCreateList.java"],
+    deps = [
+        ":attribute",
+        ":cel_value_interpretable",
+        "//common/values",
+        "//common/values:cel_value",
+        "//common/values:cel_value_provider",
+        "//runtime:evaluation_exception",
+        "//runtime:interpretable",
+        "@maven//:com_google_errorprone_error_prone_annotations",
+        "@maven//:com_google_guava_guava",
+    ],
+)
+
 java_library(
     name = "eval_create_map",
     srcs = ["EvalCreateMap.java"],

runtime/src/main/java/dev/cel/runtime/planner/EvalCreateList.java

@@ -0,0 +1,37 @@
+package dev.cel.runtime.planner;
+
+import com.google.common.collect.ImmutableList;
+import com.google.errorprone.annotations.Immutable;
+import dev.cel.common.values.CelValue;
+import dev.cel.common.values.ImmutableListValue;
+import dev.cel.runtime.CelEvaluationException;
+import dev.cel.runtime.GlobalResolver;
+
+@Immutable
+final class EvalCreateList implements CelValueInterpretable {
+
+  @SuppressWarnings("Immutable")
+  private final CelValueInterpretable[] values;
+
+
+  @Override
+  public CelValue eval(GlobalResolver resolver) throws CelEvaluationException {
+    ImmutableList.Builder<CelValue> builder = ImmutableList.builder();
+    for (int i = 0; i < values.length; i++) {
+      builder.add(values[i].eval(resolver));
+    }
+    return ImmutableListValue.create(builder.build());
+  }
+
+  static EvalCreateList create(
+      CelValueInterpretable[] values
+  ) {
+    return new EvalCreateList(values);
+  }
+
+  private EvalCreateList(
+      CelValueInterpretable[] values
+  ) {
+    this.values = values;
+  }
+}

runtime/src/main/java/dev/cel/runtime/planner/ProgramPlanner.java

@@ -10,6 +10,7 @@
 import dev.cel.common.ast.CelConstant;
 import dev.cel.common.ast.CelExpr;
 import dev.cel.common.ast.CelExpr.CelCall;
+import dev.cel.common.ast.CelExpr.CelList;
 import dev.cel.common.ast.CelExpr.CelMap;
 import dev.cel.common.ast.CelExpr.CelStruct;
 import dev.cel.common.ast.CelExpr.CelStruct.Entry;
@@ -53,7 +54,7 @@ private CelValueInterpretable plan(
       case CALL:
         return planCall(celExpr, ctx);
       case LIST:
-        break;
+        return planCreateList(celExpr, ctx);
       case STRUCT:
         return planCreateStruct(celExpr, ctx);
       case MAP:
@@ -169,6 +170,19 @@ private CelValueInterpretable planCreateStruct(CelExpr celExpr, PlannerContext c
     return EvalCreateStruct.create(valueProvider, struct.messageName(), keys, values);
   }
 
+  private CelValueInterpretable planCreateList(CelExpr celExpr, PlannerContext ctx) {
+    CelList list = celExpr.list();
+
+    List<CelExpr> elements = list.elements();
+    CelValueInterpretable[] values = new CelValueInterpretable[elements.size()];
+
+    for (int i = 0; i < elements.size(); i++) {
+      values[i] = plan(elements.get(i), ctx);
+    }
+
+    return EvalCreateList.create(values);
+  }
+
   private CelValueInterpretable planCreateMap(CelExpr celExpr, PlannerContext ctx) {
     CelMap map = celExpr.map();
 

runtime/src/test/java/dev/cel/runtime/planner/ProgramPlannerTest.java

@@ -52,6 +52,7 @@
 import java.nio.charset.StandardCharsets;
 
 import dev.cel.runtime.DefaultDispatcher;
+import java.util.List;
 import java.util.Map;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -234,6 +235,17 @@ public void planCreateStruct_withFields() throws Exception {
     assertThat(result).isEqualTo(TestAllTypes.newBuilder().setSingleString("foo").setSingleBool(true).build());
   }
 
+  @Test
+  public void planCreateList() throws Exception {
+    CelAbstractSyntaxTree ast = compile("[1, 'foo', true]");
+
+    Program program = PLANNER.plan(ast);
+
+    List<Object> result = (List<Object>) program.eval();
+
+    assertThat(result).containsExactly(1L, "foo", true).inOrder();
+  }
+
   @Test
   public void planCreateMap() throws Exception {
     CelAbstractSyntaxTree ast = compile("{'foo': 1, true: 'bar'}");