Check Kubernetes cluster endpoint for defining the ssl_ca_cert#5143
Merged
Conversation
javanlacerda
force-pushed
the
javan.utask-google-auth
branch
2 times, most recently
from
b77fe79 to
0b2cac9
Compare
javanlacerda
force-pushed
the
javan.utask-google-auth
branch
2 times, most recently
from
859f3cd to
11414f2
Compare
Signed-off-by: Javan Lacerda <javanlacerda@google.com>
javanlacerda
force-pushed
the
javan.utask-google-auth
branch
from
11414f2 to
14d1b0d
Compare
ViniciustCosta
approved these changes
Jan 26, 2026
javanlacerda
added a commit
that referenced
this pull request
Feb 4, 2026
This is a follow up in the Kubernetes service implementation for running untrusted jobs. The current implementation was working for dev environment because the K8s cluster is set there with default configurations. During the rollout for the external project, the cluster needed to be created with security rules, and one of them is having a private ip, and set the DNS to resolve both internal and external ips. As the endpoint for this cluster is a name (defined by the dns) and not a ip, we shouldn't set the ssl certificate, as the authentication will be managed by the DNS. This PR updates the load credentials function to check the cluster endpoint and only set the ssl cert if the endpoint is a ip. Signed-off-by: Javan Lacerda <javanlacerda@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up in the Kubernetes service implementation for running untrusted jobs.
The current implementation was working for dev environment because the K8s cluster is set there with default configurations.
During the rollout for the external project, the cluster needed to be created with security rules, and one of them is having a private ip, and set the DNS to resolve both internal and external ips.
As the endpoint for this cluster is a name (defined by the dns) and not a ip, we shouldn't set the ssl certificate, as the authentication will be managed by the DNS.
This PR updates the load credentials function to check the cluster endpoint and only set the ssl cert if the endpoint is a ip.