Swarming: Fuzzing hours to be logged in metrics#5248
Open
Swarming: Fuzzing hours to be logged in metrics#5248
Conversation
IvanBM18
added
the
swarming
jardondiego
requested review from
ViniciustCosta,
jardondiego,
javanlacerda and
letitz
jardondiego
reviewed
Apr 22, 2026
jardondiego
reviewed
Apr 22, 2026
jardondiego
reviewed
Apr 22, 2026
jardondiego
reviewed
Apr 28, 2026
IvanBM18
commented
Apr 28, 2026
| _default_extras = {} | ||
|
|
||
|
|
||
| def _is_running_on_k8s(): |
Collaborator
Author
There was a problem hiding this comment.
Now that we dont have a circular dependency we can start using the same method that its declared on environment.py
IvanBM18
commented
Apr 28, 2026
| os.getenv('SERVER_SOFTWARE', '').startswith('Development/')) | ||
|
|
||
|
|
||
| def _is_running_on_app_engine(): |
Collaborator
Author
There was a problem hiding this comment.
Same as above:
Now that we dont have a circular dependency we can start using the same method that its declared on environment.py
Collaborator
|
It looks like we have failing tests. Can you take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if we run fuzzing sessions on swarming, the metrics dont seem to register those fuzzing hours correctly:
Note that the swarming fuzzing hours appear as empty:
runtime=logs<->environmentmodules, i removed some methods that were declared twice to avoid this circular dependency and correctly imported them from a single module