Idiomatic: Rework Option-in-Drop example to emphasize move semantics#3168
Merged
mgeisler merged 1 commit intogoogle:mainfrom Apr 28, 2026
Merged
Conversation
mgeisler
approved these changes
Apr 20, 2026
Contributor
Author
|
@mgeisler can you hit the merge button if this looks good? I no longer have permissions to do so myself for some reason. |
Collaborator
Yes! Sorry about the delay — @gribozavr, can you help with permissions here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework the example in the "Drop: Option" slide to emphasize how
Optionis used to achieve move operations inDropcode. The current version of the slide emphasizes the wrong thing in my opinion, and fails to actually demonstrate the pattern of needing to perform a move operation indrop. I've modifiedHandleto have afn close(self)instead of aDropimpl, that wayFile::dropneeds to move out of its inner field in order to callclose.