Commit 761de8f
authored
Avoid longs when specifying precision in a sprintf argument. (#1041)
Causes a compiler warning which is treated as error when building
for the Android platform.
Note 1: Simply casting to an int here as no real harm can befall
us if it wraps or gets treated as negative.
Note 2: Given that JNI tracing is a compile time option (there's
a constant in trace.cc) we should probably re-write the JNI_TRACE
macro to expand to nothing unless it is enabled, as currently we
are wasting several k on format strings that will never be used.
This would also improve our coverage metrics for trace messages
that are never reached by tests too ;) I shall do that as a
follow-up1 parent 8c00322 commit 761de8f
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4193 | 4193 | | |
4194 | 4194 | | |
4195 | 4195 | | |
4196 | | - | |
| 4196 | + | |
4197 | 4197 | | |
4198 | 4198 | | |
4199 | 4199 | | |
| |||
0 commit comments