Skip to content

Commit e3ee5ed

Browse files
OmniLab Teamcopybara-github
authored andcommitted
Internal change
PiperOrigin-RevId: 944995298
1 parent 2a475c5 commit e3ee5ed

4 files changed

Lines changed: 7 additions & 9 deletions

File tree

src/devtools/mobileharness/fe/v6/angular/app/core/services/host/fake_host_service.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -328,12 +328,11 @@ TX errors 0 dropped 0 overruns 0 carrier 0 collisions 0`,
328328
override preflightLabServerLifecycle(
329329
hostName: string,
330330
action: LifecycleActionType,
331-
expectedActivity: string,
332331
): Observable<PreflightLabServerLifecycleResponse> {
333-
// Default fake: always return ready with the expected activity.
332+
// Default fake: always return ready with a mock running activity.
334333
return of({
335334
ready: {
336-
actualActivity: expectedActivity,
335+
actualActivity: 'RUNNING',
337336
},
338337
}).pipe(delay(1000));
339338
}

src/devtools/mobileharness/fe/v6/angular/app/core/services/host/host_service.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,6 @@ export abstract class HostService {
8989
abstract preflightLabServerLifecycle(
9090
hostName: string,
9191
action: LifecycleActionType,
92-
expectedActivity: string,
9392
): Observable<PreflightLabServerLifecycleResponse>;
9493

9594
/**

src/devtools/mobileharness/fe/v6/angular/app/core/services/host/http_host_service.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,13 +103,11 @@ export class HttpHostService extends HostService {
103103
override preflightLabServerLifecycle(
104104
hostName: string,
105105
action: LifecycleActionType,
106-
expectedActivity: string,
107106
): Observable<PreflightLabServerLifecycleResponse> {
108107
return this.http.post<PreflightLabServerLifecycleResponse>(
109108
`${this.apiUrl}/${hostName}:preflightLifecycle`,
110109
{
111110
action,
112-
expectedActivity,
113111
},
114112
);
115113
}

src/devtools/mobileharness/fe/v6/service/proto/host/host_service.proto

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -313,9 +313,11 @@ message PreflightLabServerLifecycleRequest {
313313

314314
LifecycleActionType action = 2;
315315

316-
// The Activity currently displayed on the Lab Server card in the frontend.
317-
// Used to detect stale page state (e.g. "RUNNING", "STOPPED").
318-
string expected_activity = 3;
316+
// Field 3 was a previously-planned `expected_activity` for stale-page
317+
// detection. The backend determines availability from the freshly-fetched
318+
// actual_activity instead, so the field was removed.
319+
reserved 3;
320+
reserved "expected_activity";
319321

320322
// The universe of the host.
321323
string universe = 4;

0 commit comments

Comments
 (0)