Internal change

PiperOrigin-RevId: 896413542

Author: DeviceInfra

src/java/com/google/devtools/mobileharness/fe/v6/service/host/BUILD

@@ -38,6 +38,7 @@ java_library(
         "//src/devtools/mobileharness/fe/v6/service/proto/host:host_resources_java_proto",
         "//src/devtools/mobileharness/fe/v6/service/proto/host:host_service_java_proto",
         "//src/java/com/google/devtools/mobileharness/fe/v6/service/host/handlers",
+        "//src/java/com/google/devtools/mobileharness/fe/v6/service/util",
         "@maven//:com_google_guava_guava",
         "@maven//:javax_inject_jsr330_api",
     ],

src/java/com/google/devtools/mobileharness/fe/v6/service/host/HostServiceLogicImpl.java

@@ -16,10 +16,12 @@
 
 package com.google.devtools.mobileharness.fe.v6.service.host;
 
+import static com.google.common.util.concurrent.Futures.immediateFailedFuture;
 import static com.google.common.util.concurrent.Futures.immediateFuture;
 
 import com.google.common.util.concurrent.ListenableFuture;
 import com.google.devtools.mobileharness.fe.v6.service.host.handlers.GetHostDeviceSummariesHandler;
+import com.google.devtools.mobileharness.fe.v6.service.host.handlers.GetHostHeaderInfoHandler;
 import com.google.devtools.mobileharness.fe.v6.service.host.handlers.GetHostOverviewHandler;
 import com.google.devtools.mobileharness.fe.v6.service.proto.host.CheckRemoteControlEligibilityRequest;
 import com.google.devtools.mobileharness.fe.v6.service.proto.host.CheckRemoteControlEligibilityResponse;
@@ -37,7 +39,6 @@
 import com.google.devtools.mobileharness.fe.v6.service.proto.host.GetPopularFlagsResponse;
 import com.google.devtools.mobileharness.fe.v6.service.proto.host.GetReleaseConfigsRequest;
 import com.google.devtools.mobileharness.fe.v6.service.proto.host.GetReleaseConfigsResponse;
-import com.google.devtools.mobileharness.fe.v6.service.proto.host.HostActions;
 import com.google.devtools.mobileharness.fe.v6.service.proto.host.HostHeaderInfo;
 import com.google.devtools.mobileharness.fe.v6.service.proto.host.HostOverviewPageData;
 import com.google.devtools.mobileharness.fe.v6.service.proto.host.ReleaseLabServerRequest;
@@ -52,6 +53,8 @@
 import com.google.devtools.mobileharness.fe.v6.service.proto.host.StopLabServerResponse;
 import com.google.devtools.mobileharness.fe.v6.service.proto.host.UpdatePassThroughFlagsRequest;
 import com.google.devtools.mobileharness.fe.v6.service.proto.host.UpdatePassThroughFlagsResponse;
+import com.google.devtools.mobileharness.fe.v6.service.util.UniverseFactory;
+import com.google.devtools.mobileharness.fe.v6.service.util.UniverseScope;
 import javax.inject.Inject;
 import javax.inject.Singleton;
 
@@ -61,38 +64,53 @@ public final class HostServiceLogicImpl implements HostServiceLogic {
 
   private final GetHostOverviewHandler getHostOverviewHandler;
   private final GetHostDeviceSummariesHandler getHostDeviceSummariesHandler;
+  private final GetHostHeaderInfoHandler getHostHeaderInfoHandler;
+  private final UniverseFactory universeFactory;
 
   @Inject
   HostServiceLogicImpl(
       GetHostOverviewHandler getHostOverviewHandler,
-      GetHostDeviceSummariesHandler getHostDeviceSummariesHandler) {
+      GetHostDeviceSummariesHandler getHostDeviceSummariesHandler,
+      GetHostHeaderInfoHandler getHostHeaderInfoHandler,
+      UniverseFactory universeFactory) {
     this.getHostOverviewHandler = getHostOverviewHandler;
     this.getHostDeviceSummariesHandler = getHostDeviceSummariesHandler;
+    this.getHostHeaderInfoHandler = getHostHeaderInfoHandler;
+    this.universeFactory = universeFactory;
   }
 
   @Override
   public ListenableFuture<HostHeaderInfo> getHostHeaderInfo(GetHostHeaderInfoRequest request) {
-    // TODO: - dafeng - Use the universe parameter.
-    @SuppressWarnings("unused")
-    String universe = request.getUniverse();
-
-    // TODO: Implement this method.
-    return immediateFuture(
-        HostHeaderInfo.newBuilder()
-            .setHostName(request.getHostName())
-            .setActions(HostActions.getDefaultInstance())
-            .build());
+    UniverseScope universe;
+    try {
+      universe = universeFactory.create(request.getUniverse());
+    } catch (IllegalArgumentException e) {
+      return immediateFailedFuture(e);
+    }
+    return getHostHeaderInfoHandler.getHostHeaderInfo(request, universe);
   }
 
   @Override
   public ListenableFuture<HostOverviewPageData> getHostOverview(GetHostOverviewRequest request) {
-    return getHostOverviewHandler.getHostOverview(request);
+    UniverseScope universe;
+    try {
+      universe = universeFactory.create(request.getUniverse());
+    } catch (IllegalArgumentException e) {
+      return immediateFailedFuture(e);
+    }
+    return getHostOverviewHandler.getHostOverview(request, universe);
   }
 
   @Override
   public ListenableFuture<GetHostDeviceSummariesResponse> getHostDeviceSummaries(
       GetHostDeviceSummariesRequest request) {
-    return getHostDeviceSummariesHandler.getHostDeviceSummaries(request);
+    UniverseScope universe;
+    try {
+      universe = universeFactory.create(request.getUniverse());
+    } catch (IllegalArgumentException e) {
+      return immediateFailedFuture(e);
+    }
+    return getHostDeviceSummariesHandler.getHostDeviceSummaries(request, universe);
   }
 
   @Override

src/java/com/google/devtools/mobileharness/fe/v6/service/host/handlers/BUILD

@@ -41,6 +41,7 @@ java_library(
         "//src/java/com/google/devtools/mobileharness/fe/v6/service/shared",
         "//src/java/com/google/devtools/mobileharness/fe/v6/service/shared/providers:lab_info_provider",
         "//src/java/com/google/devtools/mobileharness/fe/v6/service/shared/remotecontrol",
+        "//src/java/com/google/devtools/mobileharness/fe/v6/service/util",
         "//src/java/com/google/devtools/mobileharness/shared/util/logging:google_logger",
         "@maven//:com_google_guava_guava",
         "@maven//:javax_inject_jsr330_api",

src/java/com/google/devtools/mobileharness/fe/v6/service/host/handlers/GetHostDeviceSummariesHandler.java

@@ -45,6 +45,7 @@
 import com.google.devtools.mobileharness.fe.v6.service.shared.remotecontrol.RemoteControlEligibilityChecker;
 import com.google.devtools.mobileharness.fe.v6.service.shared.remotecontrol.RemoteControlEligibilityContext;
 import com.google.devtools.mobileharness.fe.v6.service.shared.remotecontrol.RemoteControlEligibilityResult;
+import com.google.devtools.mobileharness.fe.v6.service.util.UniverseScope;
 import com.google.devtools.mobileharness.shared.labinfo.proto.LabInfoServiceProto.GetLabInfoRequest;
 import com.google.devtools.mobileharness.shared.labinfo.proto.LabInfoServiceProto.GetLabInfoResponse;
 import javax.inject.Inject;
@@ -81,13 +82,11 @@ public final class GetHostDeviceSummariesHandler {
 
   /** Gets host device summaries. */
   public ListenableFuture<GetHostDeviceSummariesResponse> getHostDeviceSummaries(
-      GetHostDeviceSummariesRequest request) {
-    // TODO: - dafeng - Use the universe parameter.
-    @SuppressWarnings("unused")
-    String universe = request.getUniverse();
+      GetHostDeviceSummariesRequest request, UniverseScope universe) {
+
     GetLabInfoRequest getLabInfoRequest = createGetLabInfoRequest(request.getHostName());
     return Futures.transform(
-        labInfoProvider.getLabInfoAsync(getLabInfoRequest, ""),
+        labInfoProvider.getLabInfoAsync(getLabInfoRequest, universe),
         this::processLabInfoResponse,
         executor);
   }

src/java/com/google/devtools/mobileharness/fe/v6/service/host/handlers/GetHostHeaderInfoHandler.java

@@ -0,0 +1,55 @@
+/*
+ * Copyright 2022 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *    https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.google.devtools.mobileharness.fe.v6.service.host.handlers;
+
+import static com.google.common.util.concurrent.Futures.immediateFuture;
+
+import com.google.common.util.concurrent.ListenableFuture;
+import com.google.devtools.mobileharness.fe.v6.service.proto.host.GetHostHeaderInfoRequest;
+import com.google.devtools.mobileharness.fe.v6.service.proto.host.HostActions;
+import com.google.devtools.mobileharness.fe.v6.service.proto.host.HostHeaderInfo;
+import com.google.devtools.mobileharness.fe.v6.service.util.UniverseScope;
+import javax.inject.Inject;
+import javax.inject.Singleton;
+
+/** Handler for getting host header info. */
+@Singleton
+public class GetHostHeaderInfoHandler {
+
+  @Inject
+  GetHostHeaderInfoHandler() {}
+
+  public ListenableFuture<HostHeaderInfo> getHostHeaderInfo(
+      GetHostHeaderInfoRequest request, UniverseScope universe) {
+    if (universe instanceof UniverseScope.RoutedUniverse) {
+      // Scenario 2: routed universe. Configuration is disabled.
+      return immediateFuture(
+          HostHeaderInfo.newBuilder()
+              .setHostName(request.getHostName())
+              .setActions(HostActions.getDefaultInstance()) // Empty actions
+              .build());
+    }
+
+    // Scenario 1 & 3: self universe.
+    // TODO: Implement this method fully.
+    return immediateFuture(
+        HostHeaderInfo.newBuilder()
+            .setHostName(request.getHostName())
+            .setActions(HostActions.getDefaultInstance())
+            .build());
+  }
+}

src/java/com/google/devtools/mobileharness/fe/v6/service/host/handlers/GetHostOverviewHandler.java

@@ -48,6 +48,7 @@
 import com.google.devtools.mobileharness.fe.v6.service.proto.host.HostOverviewPageData;
 import com.google.devtools.mobileharness.fe.v6.service.proto.host.LabServerInfo;
 import com.google.devtools.mobileharness.fe.v6.service.shared.providers.LabInfoProvider;
+import com.google.devtools.mobileharness.fe.v6.service.util.UniverseScope;
 import com.google.devtools.mobileharness.shared.labinfo.proto.LabInfoServiceProto.GetLabInfoRequest;
 import com.google.devtools.mobileharness.shared.labinfo.proto.LabInfoServiceProto.GetLabInfoResponse;
 import java.util.List;
@@ -74,28 +75,26 @@ public final class GetHostOverviewHandler {
     this.executor = executor;
   }
 
-  public ListenableFuture<HostOverviewPageData> getHostOverview(GetHostOverviewRequest request) {
-    // TODO: - dafeng - Use the universe parameter.
-    @SuppressWarnings("unused")
-    String universe = request.getUniverse();
+  public ListenableFuture<HostOverviewPageData> getHostOverview(
+      GetHostOverviewRequest request, UniverseScope universe) {
     logger.atInfo().log("Getting host overview for %s", request.getHostName());
     String hostName = request.getHostName();
 
     ListenableFuture<GetLabInfoResponse> labInfoFuture =
-        labInfoProvider.getLabInfoAsync(createGetLabInfoRequest(hostName), "");
+        labInfoProvider.getLabInfoAsync(createGetLabInfoRequest(hostName), universe);
 
     ListenableFuture<Optional<HostReleaseInfo>> hostReleaseInfoFuture =
-        hostAuxiliaryInfoProvider.getHostReleaseInfo(hostName);
+        hostAuxiliaryInfoProvider.getHostReleaseInfo(hostName, universe);
 
     ListenableFuture<Optional<String>> passThroughFlagsFuture =
-        hostAuxiliaryInfoProvider.getPassThroughFlags(hostName);
+        hostAuxiliaryInfoProvider.getPassThroughFlags(hostName, universe);
 
     ListenableFuture<List<DiagnosticLink>> logLinksFuture =
         Futures.transformAsync(
             hostReleaseInfoFuture,
             hostReleaseInfoOpt ->
                 hostAuxiliaryInfoProvider.getDiagnosticLinks(
-                    hostName, hostReleaseInfoOpt.flatMap(HostReleaseInfo::labType)),
+                    hostName, hostReleaseInfoOpt.flatMap(HostReleaseInfo::labType), universe),
             executor);
 
     return Futures.whenAllSucceed(

src/javatests/com/google/devtools/mobileharness/fe/v6/service/host/BUILD

@@ -0,0 +1,51 @@
+# Copyright 2022 Google LLC
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+load("@rules_java//java:java_library.bzl", "java_library")
+load("//src/javatests/com/google/devtools/mobileharness/builddefs:junit_test_suites.bzl", "junit_test_suites")
+
+package(
+    default_applicable_licenses = ["//:license"],
+)
+
+java_library(
+    name = "host",
+    testonly = 1,
+    srcs = glob(["*.java"]),
+    deps = [
+        "//src/devtools/mobileharness/fe/v6/service/proto/host:host_resources_java_proto",
+        "//src/devtools/mobileharness/fe/v6/service/proto/host:host_service_java_proto",
+        "//src/java/com/google/devtools/mobileharness/fe/v6/service/host:host_service_logic_impl",
+        "//src/java/com/google/devtools/mobileharness/fe/v6/service/host/provider",
+        "//src/java/com/google/devtools/mobileharness/fe/v6/service/shared",
+        "//src/java/com/google/devtools/mobileharness/fe/v6/service/shared/providers:lab_info_provider",
+        "//src/java/com/google/devtools/mobileharness/fe/v6/service/shared/remotecontrol",
+        "//src/java/com/google/devtools/mobileharness/fe/v6/service/util",
+        "//src/javatests/com/google/devtools/mobileharness/builddefs:truth",
+        "@maven//:com_google_guava_guava",
+        "@maven//:com_google_inject_extensions_guice_testlib",
+        "@maven//:com_google_inject_guice",
+        "@maven//:junit_junit",
+        "@maven//:org_mockito_mockito_core",
+    ],
+)
+
+junit_test_suites(
+    name = "gen_tests",
+    sizes = [
+        "small",
+    ],
+    deps = [":host"],
+)

src/javatests/com/google/devtools/mobileharness/fe/v6/service/host/HostServiceLogicImplTest.java

@@ -0,0 +1,94 @@
+/*
+ * Copyright 2022 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *    https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.google.devtools.mobileharness.fe.v6.service.host;
+
+import static com.google.common.truth.Truth.assertThat;
+import static com.google.common.util.concurrent.MoreExecutors.newDirectExecutorService;
+import static org.junit.Assert.assertThrows;
+import static org.mockito.ArgumentMatchers.anyString;
+import static org.mockito.Mockito.when;
+
+import com.google.common.util.concurrent.ListeningExecutorService;
+import com.google.devtools.mobileharness.fe.v6.service.host.provider.HostAuxiliaryInfoProvider;
+import com.google.devtools.mobileharness.fe.v6.service.proto.host.GetHostHeaderInfoRequest;
+import com.google.devtools.mobileharness.fe.v6.service.proto.host.HostActions;
+import com.google.devtools.mobileharness.fe.v6.service.proto.host.HostHeaderInfo;
+import com.google.devtools.mobileharness.fe.v6.service.shared.SubDeviceInfoListFactory;
+import com.google.devtools.mobileharness.fe.v6.service.shared.providers.LabInfoProvider;
+import com.google.devtools.mobileharness.fe.v6.service.shared.remotecontrol.RemoteControlEligibilityChecker;
+import com.google.devtools.mobileharness.fe.v6.service.util.UniverseFactory;
+import com.google.devtools.mobileharness.fe.v6.service.util.UniverseScope;
+import com.google.inject.Guice;
+import com.google.inject.testing.fieldbinder.Bind;
+import com.google.inject.testing.fieldbinder.BoundFieldModule;
+import java.time.InstantSource;
+import java.util.concurrent.ExecutionException;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.JUnit4;
+import org.mockito.Mock;
+import org.mockito.junit.MockitoJUnit;
+import org.mockito.junit.MockitoRule;
+
+@RunWith(JUnit4.class)
+public final class HostServiceLogicImplTest {
+
+  @Rule public final MockitoRule mocks = MockitoJUnit.rule();
+
+  @Bind @Mock private LabInfoProvider labInfoProvider;
+  @Bind @Mock private HostAuxiliaryInfoProvider hostAuxiliaryInfoProvider;
+  @Bind @Mock private SubDeviceInfoListFactory subDeviceInfoListFactory;
+  @Bind @Mock private RemoteControlEligibilityChecker remoteControlEligibilityChecker;
+  @Bind private final ListeningExecutorService executor = newDirectExecutorService();
+  @Bind @Mock private UniverseFactory universeFactory;
+  @Bind @Mock private InstantSource instantSource;
+
+  private HostServiceLogicImpl hostServiceLogicImpl;
+
+  @Before
+  public void setUp() {
+    when(universeFactory.create(anyString())).thenReturn(new UniverseScope.SelfUniverse());
+    hostServiceLogicImpl =
+        Guice.createInjector(BoundFieldModule.of(this)).getInstance(HostServiceLogicImpl.class);
+  }
+
+  @Test
+  public void getHostHeaderInfo_success() throws Exception {
+    GetHostHeaderInfoRequest request =
+        GetHostHeaderInfoRequest.newBuilder().setHostName("host").build();
+
+    HostHeaderInfo response = hostServiceLogicImpl.getHostHeaderInfo(request).get();
+
+    assertThat(response.getHostName()).isEqualTo("host");
+    assertThat(response.getActions()).isEqualTo(HostActions.getDefaultInstance());
+  }
+
+  @Test
+  public void getHostHeaderInfo_invalidUniverse_fails() throws Exception {
+    GetHostHeaderInfoRequest request =
+        GetHostHeaderInfoRequest.newBuilder().setHostName("host").setUniverse("invalid").build();
+
+    when(universeFactory.create("invalid")).thenThrow(new IllegalArgumentException("invalid"));
+
+    ExecutionException e =
+        assertThrows(
+            ExecutionException.class, () -> hostServiceLogicImpl.getHostHeaderInfo(request).get());
+    assertThat(e).hasCauseThat().isInstanceOf(IllegalArgumentException.class);
+  }
+}