Fix an infinite recursion bug in PreferCharsetOverload.

See also unknown commit

PiperOrigin-RevId: 929887275

Author: kluever

core/src/main/java/com/google/errorprone/bugpatterns/PreferCharsetOverload.java

@@ -42,6 +42,7 @@
 import com.google.errorprone.suppliers.Supplier;
 import com.sun.source.tree.ExpressionTree;
 import com.sun.source.tree.MethodInvocationTree;
+import com.sun.source.tree.MethodTree;
 import com.sun.source.tree.NewClassTree;
 import com.sun.source.tree.Tree.Kind;
 import com.sun.tools.javac.code.Symbol.MethodSymbol;
@@ -102,6 +103,11 @@ private Description match(
       return Description.NO_MATCH;
     }
 
+    MethodTree enclosingMethod = state.findEnclosing(MethodTree.class);
+    if (enclosingMethod != null && getSymbol(enclosingMethod).equals(bestOverload)) {
+      return Description.NO_MATCH;
+    }
+
     // 3. Build the fix to use the Charset overload.
     SuggestedFix fix = buildFix(arguments, bestOverload, candidateIndices, state);
     return fix != null ? describeMatch(tree, fix) : Description.NO_MATCH;

core/src/test/java/com/google/errorprone/bugpatterns/PreferCharsetOverloadTest.java

@@ -439,4 +439,28 @@ void test() {
             """)
         .doTest();
   }
+
+  @Test
+  public void negativeDelegatingConstructor() {
+    helper
+        .addInputLines(
+            "JavaStringDecoder.java",
+            """
+            import java.nio.charset.Charset;
+
+            public class JavaStringDecoder {
+              private final String charsetName;
+
+              public JavaStringDecoder(Charset charset) {
+                this(charset.name());
+              }
+
+              public JavaStringDecoder(String charsetName) {
+                this.charsetName = charsetName;
+              }
+            }
+            """)
+        .expectUnchanged()
+        .doTest();
+  }
 }