Remove references to EasyMock, which was deleted 3+ years ago (unknown commit).

Push `MOCKED_VAR` up to the base class.

PiperOrigin-RevId: 903340783

Author: kluever

core/src/main/java/com/google/errorprone/bugpatterns/AbstractMockChecker.java

@@ -42,7 +42,6 @@
 import java.util.Optional;
 import java.util.function.Function;
 import java.util.function.Supplier;
-import java.util.regex.Pattern;
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
 import org.jspecify.annotations.Nullable;
@@ -212,21 +211,21 @@ public static TypeExtractor<VariableTree> fieldAnnotatedWithOneOf(
   }
 
   /**
-   * A TypeExtractor for method invocations that create a mock using Mockito.mock, Mockito.spy, or
-   * EasyMock.create[...]Mock, extracting the type being mocked.
+   * A {@link TypeExtractor} that extracts the type being mocked for method invocations that use
+   * either {@code org.mockito.Mockito.mock(...)} or {@code org.mockito.Mockito.spy(...)}.
    */
   public static final TypeExtractor<MethodInvocationTree> MOCKING_METHOD =
       extractFirstArg(
-              Matchers.toType(
-                  MethodInvocationTree.class,
-                  Matchers.staticMethod().onClass("org.mockito.Mockito").namedAnyOf("mock", "spy")))
-          .or(
-              extractClassArg(
-                  Matchers.toType(
-                      MethodInvocationTree.class,
-                      Matchers.staticMethod()
-                          .onClass("org.easymock.EasyMock")
-                          .withNameMatching(Pattern.compile("^create.*Mock(Builder)?$")))));
+          Matchers.toType(
+              MethodInvocationTree.class,
+              Matchers.staticMethod().onClass("org.mockito.Mockito").namedAnyOf("mock", "spy")));
+
+  /**
+   * A {@link TypeExtractor} that extracts the type of a variable declaration that is annotated with
+   * either {@code @org.mockito.Mock} or {@code @org.mockito.Spy}.
+   */
+  public static final TypeExtractor<VariableTree> MOCKED_VAR =
+      fieldAnnotatedWithOneOf(Stream.of("org.mockito.Mock", "org.mockito.Spy"));
 
   @Override
   public final Description matchMethodInvocation(MethodInvocationTree tree, VisitorState state) {

core/src/main/java/com/google/errorprone/bugpatterns/DoNotMockAutoValue.java

@@ -20,8 +20,6 @@
 
 import com.google.auto.value.AutoValue;
 import com.google.errorprone.BugPattern;
-import com.sun.source.tree.VariableTree;
-import java.util.stream.Stream;
 
 /** Suggests not mocking AutoValue classes. */
 @BugPattern(
@@ -30,8 +28,6 @@
             + " Construct a real instance of the class instead.",
     severity = WARNING)
 public final class DoNotMockAutoValue extends AbstractMockChecker<AutoValue> {
-  private static final TypeExtractor<VariableTree> MOCKED_VAR =
-      fieldAnnotatedWithOneOf(Stream.of("org.mockito.Mock", "org.mockito.Spy"));
 
   public DoNotMockAutoValue() {
     super(

core/src/main/java/com/google/errorprone/bugpatterns/DoNotMockChecker.java

@@ -19,12 +19,10 @@
 import com.google.errorprone.BugPattern;
 import com.google.errorprone.BugPattern.SeverityLevel;
 import com.google.errorprone.annotations.DoNotMock;
-import com.sun.source.tree.VariableTree;
-import java.util.stream.Stream;
 
 /**
- * Points out if a Mockito or EasyMock mock is mocking an object that would be better off being
- * tested using an alternative instance.
+ * Points out if a Mockito mock is mocking an object that would be better off being tested using an
+ * alternative instance.
  *
  * @author amalloy@google.com (Alan Malloy)
  */
@@ -35,9 +33,6 @@
     documentSuppression = false)
 public class DoNotMockChecker extends AbstractMockChecker<DoNotMock> {
 
-  private static final TypeExtractor<VariableTree> MOCKED_VAR =
-      fieldAnnotatedWithOneOf(Stream.of("org.mockito.Mock", "org.mockito.Spy"));
-
   public DoNotMockChecker() {
     super(MOCKED_VAR, MOCKING_METHOD, DoNotMock.class, DoNotMock::value);
   }