Skip to content

Commit aa994bd

Browse files
cushonError Prone Team
authored andcommitted
Update some expected test outputs
These tests pass with AST_MATCH, but not TEXT_MATCH. This update prepares for making TEXT_MATCH the default. PiperOrigin-RevId: 888753676
1 parent 5ebde4c commit aa994bd

5 files changed

Lines changed: 17 additions & 3 deletions

File tree

core/src/test/java/com/google/errorprone/bugpatterns/AnnotationPositionTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -559,6 +559,7 @@ interface T {
559559
"Test.java",
560560
"""
561561
interface T {
562+
562563
<T> @TypeUse T f();
563564
}
564565
""")
@@ -584,6 +585,7 @@ interface T {
584585
import java.util.List;
585586
586587
interface T {
588+
587589
<T extends List<T>> @TypeUse T f();
588590
}
589591
""")

core/src/test/java/com/google/errorprone/bugpatterns/UnusedVariableTest.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -493,10 +493,13 @@ void test() {
493493
package unusedvars;
494494
495495
public class Unuseds {
496+
496497
private static final String CONST_STR = "test";
498+
497499
public int publicOne;
498500
499501
void test() {
502+
500503
System.out.println(CONST_STR);
501504
}
502505
}
@@ -968,6 +971,7 @@ void test() {
968971
import com.google.common.collect.ImmutableList;
969972
970973
class Test {
974+
971975
void test() {}
972976
}
973977
""")
@@ -1036,6 +1040,7 @@ class Test {
10361040
int a = foo();
10371041
10381042
private int foo() {
1043+
10391044
return 1;
10401045
}
10411046
}
@@ -1244,6 +1249,7 @@ public int a() {
12441249
"Test.java",
12451250
"""
12461251
class Test {
1252+
12471253
public int a() {
12481254
a();
12491255
return 1;
@@ -1272,6 +1278,7 @@ void foo() {
12721278
"""
12731279
class Test {
12741280
void foo() {
1281+
12751282
if (hashCode() > 0) {}
12761283
}
12771284
}
@@ -1417,6 +1424,7 @@ public String test() {
14171424
14181425
public class Test {
14191426
public String test() {
1427+
14201428
hashCode();
14211429
String a = toString();
14221430
return a;
@@ -1481,6 +1489,7 @@ public void test() {
14811489
14821490
public class Test {
14831491
public void test() {
1492+
14841493
int a = 3;
14851494
System.out.println(a);
14861495
}
@@ -1900,6 +1909,7 @@ public void test() {
19001909
"""
19011910
public class Test {
19021911
public void test() {
1912+
19031913
Integer a = 3;
19041914
a.hashCode();
19051915
}
@@ -2191,6 +2201,7 @@ public static void main(String[] args) {
21912201
21922202
class Test {
21932203
public static void main(String[] args) {
2204+
21942205
var _ = new Object();
21952206
21962207
Collections.sort(Arrays.asList(args), (a, _) -> a.isEmpty() ? 1 : 0);

core/src/test/java/com/google/errorprone/bugpatterns/inlineme/InlinerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1444,7 +1444,7 @@ public void doTest() {
14441444
public final class Caller {
14451445
public void doTest() {
14461446
Client client = new Client();
1447-
boolean x = (client.after(/* false= */ false) || true);
1447+
boolean x = (client.after(/* foo= */ false) || true);
14481448
}
14491449
}
14501450
""")

core/src/test/java/com/google/errorprone/bugpatterns/nullness/ReturnMissingNullableTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2161,8 +2161,7 @@ class Nullable {}
21612161
"out/Test.java",
21622162
"""
21632163
class T {
2164-
@org.jspecify.annotations.Nullable
2165-
private final Object method(boolean b) {
2164+
private final @org.jspecify.annotations.Nullable Object method(boolean b) {
21662165
return b ? null : 0;
21672166
}
21682167

core/src/test/java/com/google/errorprone/fixes/SuggestedFixesTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1701,6 +1701,7 @@ void f() {
17011701
"""
17021702
class Test {
17031703
void f() {
1704+
17041705
int y = 1;
17051706
System.err.println(y);
17061707
}
@@ -1729,6 +1730,7 @@ void f() {
17291730
"""
17301731
class Test {
17311732
void f() {
1733+
17321734
int y = 1;
17331735
System.err.println(y);
17341736
}

0 commit comments

Comments
 (0)