Skip to content

Commit b282fa2

Browse files
cushonError Prone Team
authored andcommitted
Improve error message for ExposedPrivateType
The diagnostic message now includes the name of the non-private member that is exposing a private type PiperOrigin-RevId: 899711391
1 parent 00d4c36 commit b282fa2

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

core/src/main/java/com/google/errorprone/bugpatterns/ExposedPrivateType.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,8 @@ private Description report(Tree tree, VisitorState state) {
176176
description.addFix(increaseVisibility.build());
177177
description.setMessage(
178178
String.format(
179-
"Signatures of non-private members should not reference private classes: %s",
179+
"Signature of non-private member '%s' should not reference private classes: %s",
180+
getSymbol(tree).getSimpleName(),
180181
found.stream().map(s -> s.getSimpleName()).collect(joining(", "))));
181182
return description.build();
182183
}

core/src/test/java/com/google/errorprone/bugpatterns/ExposedPrivateTypeTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public void publicFieldExposingPrivateType_fails() {
4040
class Outer {
4141
private static class PrivateInner {}
4242
43-
// BUG: Diagnostic contains: PrivateInner
43+
// BUG: Diagnostic contains: non-private member 'field' should not reference private classes: PrivateInner
4444
public PrivateInner field;
4545
}
4646
""")

0 commit comments

Comments
 (0)