Make release split build as default#10018
Merged
Merged
Conversation
`-y release` now becomes the default option for ./build.sh. Fix a conflict with clean options (-c or -C) as split build will always be executed for clean options otherwise. Fix web build as it hasn't wired up with split build yet.
z3moon
force-pushed
the
zm/split-build-release
branch
from
d1177e3 to
259d15f
Compare
|
|
||
| ISSUE_SPLIT_BUILD=false | ||
| SPLIT_BUILD_TYPE="" | ||
| ISSUE_SPLIT_BUILD=true |
Collaborator
There was a problem hiding this comment.
so there no way to set this to false anymore? maybe -y should take like a none option to force the build to how it was before? do we even want a non split build option?
Contributor
Author
There was a problem hiding this comment.
I added none option to disable the split build and verified it worked as intended.
bejado
approved these changes
May 21, 2026
pixelflinger
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-y releasenow becomes the default option for ./build.sh.Fix a conflict with clean options (-c or -C) as split build will always be executed for clean options otherwise.