debug: allow environment vars to override DebugRegistry defaults#10024
Open
poweifeng wants to merge 1 commit into
Open
debug: allow environment vars to override DebugRegistry defaults#10024poweifeng wants to merge 1 commit into
poweifeng wants to merge 1 commit into
Conversation
z3moon
reviewed
May 19, 2026
bejado
approved these changes
May 20, 2026
z3moon
approved these changes
May 21, 2026
pixelflinger
approved these changes
May 21, 2026
Comment on lines
+132
to
+140
| case INT: { | ||
| int v; | ||
| if (sscanf(val, "%d", &v) == 1) { | ||
| if (*static_cast<int*>(p) != v) { | ||
| *static_cast<int*>(p) = v; | ||
| changed = true; | ||
| } | ||
| } | ||
| break; |
Collaborator
There was a problem hiding this comment.
it looks like a lot of those could be a template? (where you pass the format string).
pixelflinger
requested changes
May 21, 2026
Collaborator
pixelflinger
left a comment
pixelflinger
left a comment
There was a problem hiding this comment.
I think we should print/log each variable that is being overriden (including in release).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.