gltfio: Support textures bound to both sRGB and Linear parameters#10037
Open
bejado wants to merge 1 commit into
Open
gltfio: Support textures bound to both sRGB and Linear parameters#10037bejado wants to merge 1 commit into
bejado wants to merge 1 commit into
Conversation
poweifeng
approved these changes
May 21, 2026
| TextureProvider* provider = foundProvider->second; | ||
| assert_invariant(provider); | ||
|
|
||
| const size_t cacheIdx = (uint64_t) flags & 1; |
Contributor
There was a problem hiding this comment.
can we make this a little more clear like
const size_t cacheIdx = any(flags & TextureFlags::sRGB) ? 1 : 0;
pixelflinger
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, gltfio assumed that each
cgltf_textureslot could only ever be bound in a single color space, mapping it to a single Filament Texture format. If a single texture index was bound to parameters with conflicting color-space requirements (for example, an sRGBbaseColorTextureand a LinearocclusionTexture), the loader would trigger an assertion panic.This PR resolves this limitation by allowing a single
cgltf_textureto resolve to separate sRGB and Linear Filament texture resources under the hood when conflicting color space requirements are requested.Fixes #8449