Skip to content

Add out of bounds checks in memcpy_downward #9163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paulquiring wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −0
Open

Add out of bounds checks in memcpy_downward #9163

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab0e469
Add out of bounds checks_in_memcpy downward
paulquiring Jul 1, 2026
f5d1d77
after scripts/clang-format-git.sh
paulquiring Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions include/flatbuffers/allocator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,12 @@ class Allocator {
void memcpy_downward(uint8_t* old_p, size_t old_size, uint8_t* new_p,
size_t new_size, size_t in_use_back,
size_t in_use_front) {
FLATBUFFERS_ASSERT(in_use_back <= old_size);
FLATBUFFERS_ASSERT(in_use_back <= new_size);
memcpy(new_p + new_size - in_use_back, old_p + old_size - in_use_back,
in_use_back);
FLATBUFFERS_ASSERT(in_use_front <= old_size);
FLATBUFFERS_ASSERT(in_use_front <= new_size);
memcpy(new_p, old_p, in_use_front);
}
};
Expand Down