[Rust] Fixes Rust runtime tests not running in CI#9167
Open
csmulhern wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
cc @jtdavis777 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the Rust test scripts (which are run in CI) so that they run tests for the runtime crates.
This PR does not address:
RustTest.shand what's covered byRustTest.bat.For 2, there was an existing failure in
flatbuffers::builder::tests::with_internal_capacity_preallocates_vecs. This test was broken by #8958, as the use ofHashMapfor the string pool means there are allocations for the keys even when reserving initial capacity. This is a design issue that should be addressed by the authors of #8936 and #8958.cc @wlkrm @statxc
The immediate fix is to limit the test to no_std, where it still passes, as string pooling still uses a
Vecin theno_stdconfiguration.