Skip to content

Commit e8605a8

Browse files
committed
Merge upstream/dev: resolve CMakeLists.txt comment conflict
2 parents 24ba018 + 53bcd7a commit e8605a8

2 files changed

Lines changed: 8 additions & 3 deletions

File tree

CMakeLists.txt

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -247,8 +247,13 @@ enable_testing()
247247
find_package(GTest REQUIRED)
248248
include(GoogleTest)
249249

250-
# Local-only: see PR #917. Needed so tests linking against libgemma's
251-
# per-target SIMD symbols resolve N_EMU128:: variants too.
250+
# Tests use HWY_IS_TEST=1 with `hwy/foreach_target.h`, which expands the test
251+
# TU for every attainable SIMD target (including EMU128). libgemma's
252+
# foreach_target sources (flash_attention.cc, attention.cc, gemma.cc, vit.cc)
253+
# normally compile only for the baseline+best targets, so tests would fail to
254+
# link against per-target symbols like N_EMU128::FlashAttention. Build
255+
# libgemma for all attainable targets when tests are enabled, matching what
256+
# the tests reference.
252257
target_compile_definitions(libgemma PRIVATE HWY_IS_TEST=1)
253258

254259
set(GEMMA_TEST_FILES

ops/fast_ops-inl.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2024 Google LLC
1+
// Copyright 2026 Google LLC
22
// SPDX-License-Identifier: Apache-2.0
33
//
44
// Licensed under the Apache License, Version 2.0 (the "License");

0 commit comments

Comments
 (0)