blob/s3blob: migrate from deprecated s3/manager to s3/transfermanager#3715
Open
peczenyj wants to merge 1 commit into
Open
blob/s3blob: migrate from deprecated s3/manager to s3/transfermanager#3715peczenyj wants to merge 1 commit into
peczenyj wants to merge 1 commit into
Conversation
giautm
reviewed
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The AWS SDK v2 package
github.com/aws/aws-sdk-go-v2/feature/s3/manageris now officially deprecated in favor ofgithub.com/aws/aws-sdk-go-v2/feature/s3/transfermanager. This PR migrates thes3blobdriver to use the modern Transfer Manager client.Changes
s3manager.Uploaderwithtransfermanager.Client.NewTypedWriterto usetm.UploadObject.BeforeWriteescape hatch to expose*transfermanager.UploadObjectInputand*transfermanager.Client.go.modandsamples/go.mod.Why Replays Need Regeneration
The
transfermanagerintroduces different wire-level behavior compared to the old manager. Specifically, it often includes automatic integrity checks (likeX-Amz-Sdk-Checksum-Algorithm: CRC32) and different user-agent strings. Since the existing recorded replays intestdata/were generated using the old manager, they no longer match the requests made by the new implementation.Note to Maintainers: Please regenerate the replays against the test infrastructure as part of the merge process.