fix: drop GetBody change, keep only sanitizeURL fix

Author: YooLCD

github/github.go

@@ -559,32 +559,23 @@ func (c *Client) NewRequest(method, urlStr string, body any, opts ...RequestOpti
 		return nil, err
 	}
 
-	var rawBody []byte
+	var buf io.ReadWriter
 	if body != nil {
-		var buf bytes.Buffer
-		enc := json.NewEncoder(&buf)
+		buf = &bytes.Buffer{}
+		enc := json.NewEncoder(buf)
 		enc.SetEscapeHTML(false)
-		if err := enc.Encode(body); err != nil {
+		err := enc.Encode(body)
+		if err != nil {
 			return nil, err
 		}
-		rawBody = buf.Bytes()
 	}
 
-	var bodyReader io.Reader
-	if rawBody != nil {
-		bodyReader = bytes.NewReader(rawBody)
-	}
-	req, err := http.NewRequest(method, u.String(), bodyReader)
+	req, err := http.NewRequest(method, u.String(), buf)
 	if err != nil {
 		return nil, err
 	}
-	if rawBody != nil {
-		req.GetBody = func() (io.ReadCloser, error) {
-			return io.NopCloser(bytes.NewReader(rawBody)), nil
-		}
-	}
 
-	if rawBody != nil {
+	if body != nil {
 		req.Header.Set("Content-Type", "application/json")
 	}
 	req.Header.Set("Accept", mediaTypeV3)

github/github_test.go

@@ -749,36 +749,6 @@ func TestNewRequest_emptyBody(t *testing.T) {
 	}
 }
 
-func TestNewRequest_getBody(t *testing.T) {
-	t.Parallel()
-	c := NewClient(nil)
-
-	req, err := c.NewRequest("POST", ".", &User{Login: Ptr("l")})
-	if err != nil {
-		t.Fatalf("NewRequest returned unexpected error: %v", err)
-	}
-	if req.GetBody == nil {
-		t.Fatal("NewRequest with body did not set GetBody")
-	}
-	original, _ := io.ReadAll(req.Body)
-	rc, err := req.GetBody()
-	if err != nil {
-		t.Fatalf("GetBody returned unexpected error: %v", err)
-	}
-	replay, _ := io.ReadAll(rc)
-	if string(original) != string(replay) {
-		t.Errorf("GetBody returned %q, want %q", replay, original)
-	}
-
-	req, err = c.NewRequest("GET", ".", nil)
-	if err != nil {
-		t.Fatalf("NewRequest returned unexpected error: %v", err)
-	}
-	if req.GetBody != nil {
-		t.Fatal("NewRequest without body set GetBody unexpectedly")
-	}
-}
-
 func TestNewRequest_errorForNoTrailingSlash(t *testing.T) {
 	t.Parallel()
 	tests := []struct {