refactor: Simplify array copying (#4143)

Author: alexandear

example/codespaces/newreposecretwithxcrypto/main.go

@@ -146,8 +146,7 @@ func encryptSecretWithPublicKey(publicKey *github.PublicKey, secretName, secretV
 		return nil, fmt.Errorf("unable to decode public key: %v", err)
 	}
 
-	var boxKey [32]byte
-	copy(boxKey[:], decodedPublicKey)
+	boxKey := [32]byte(decodedPublicKey)
 	encryptedBytes, err := box.SealAnonymous([]byte{}, []byte(secretValue), &boxKey, crypto_rand.Reader)
 	if err != nil {
 		return nil, fmt.Errorf("box.SealAnonymous failed with error %w", err)

example/codespaces/newusersecretwithxcrypto/main.go

@@ -153,8 +153,7 @@ func encryptSecretWithPublicKey(publicKey *github.PublicKey, secretName, secretV
 		return nil, fmt.Errorf("base64.StdEncoding.DecodeString was unable to decode public key: %v", err)
 	}
 
-	var boxKey [32]byte
-	copy(boxKey[:], decodedPublicKey)
+	boxKey := [32]byte(decodedPublicKey)
 	encryptedBytes, err := box.SealAnonymous([]byte{}, []byte(secretValue), &boxKey, crypto_rand.Reader)
 	if err != nil {
 		return nil, fmt.Errorf("box.SealAnonymous failed with error %w", err)

example/newreposecretwithxcrypto/main.go

@@ -146,8 +146,7 @@ func encryptSecretWithPublicKey(publicKey *github.PublicKey, secretName, secretV
 		return nil, fmt.Errorf("base64.StdEncoding.DecodeString was unable to decode public key: %v", err)
 	}
 
-	var boxKey [32]byte
-	copy(boxKey[:], decodedPublicKey)
+	boxKey := [32]byte(decodedPublicKey)
 	encryptedBytes, err := box.SealAnonymous([]byte{}, []byte(secretValue), &boxKey, crypto_rand.Reader)
 	if err != nil {
 		return nil, fmt.Errorf("box.SealAnonymous failed with error %w", err)

github/github.go

@@ -506,7 +506,7 @@ func (c *Client) copy() *Client {
 		clone.client.Timeout = c.client.Timeout
 	}
 	c.rateMu.Lock()
-	copy(clone.rateLimits[:], c.rateLimits[:])
+	clone.rateLimits = c.rateLimits
 	c.rateMu.Unlock()
 	return &clone
 }