refactor!: Pass TemplateRepoRequest by value in Repositories.CreateFromTemplate (#4378)

BREAKING CHANGE: `RepositoriesService.CreateFromTemplate` now passes `body` by value and `Name` is now required and passed by value.

Author: JamBalaya56562

.golangci.yml

@@ -269,7 +269,6 @@ linters:
             - TeamAddTeamRepoOptions
             - TeamLDAPMapping
             - TeamProjectOptions
-            - TemplateRepoRequest
             - UpdateCodespaceOptions
             - UpdateDefaultSetupConfigurationOptions
             - UpdateProjectItemOptions

github/github-accessors.go

@@ -620,21 +620,19 @@ func (s *RepositoriesService) Create(ctx context.Context, org string, repo *Repo
 
 // TemplateRepoRequest represents a request to create a repository from a template.
 type TemplateRepoRequest struct {
-	// Name is required when creating a repo.
-	Name        *string `json:"name,omitempty"`
-	Owner       *string `json:"owner,omitempty"`
-	Description *string `json:"description,omitempty"`
-
-	IncludeAllBranches *bool `json:"include_all_branches,omitempty"`
-	Private            *bool `json:"private,omitempty"`
+	Name               string  `json:"name"`
+	Owner              *string `json:"owner,omitempty"`
+	Description        *string `json:"description,omitempty"`
+	IncludeAllBranches *bool   `json:"include_all_branches,omitempty"`
+	Private            *bool   `json:"private,omitempty"`
 }
 
 // CreateFromTemplate generates a repository from a template.
 //
 // GitHub API docs: https://docs.github.com/rest/repos/repos?apiVersion=2022-11-28#create-a-repository-using-a-template
 //
 //meta:operation POST /repos/{template_owner}/{template_repo}/generate
-func (s *RepositoriesService) CreateFromTemplate(ctx context.Context, templateOwner, templateRepo string, body *TemplateRepoRequest) (*Repository, *Response, error) {
+func (s *RepositoriesService) CreateFromTemplate(ctx context.Context, templateOwner, templateRepo string, body TemplateRepoRequest) (*Repository, *Response, error) {
 	u := fmt.Sprintf("repos/%v/%v/generate", templateOwner, templateRepo)
 
 	req, err := s.client.NewRequest(ctx, "POST", u, body)

github/github-accessors_test.go

@@ -341,8 +341,8 @@ func TestRepositoriesService_CreateFromTemplate(t *testing.T) {
 	t.Parallel()
 	client, mux, _ := setup(t)
 
-	templateRepoReq := &TemplateRepoRequest{
-		Name: Ptr("n"),
+	templateRepoReq := TemplateRepoRequest{
+		Name: "n",
 	}
 
 	mux.HandleFunc("/repos/to/tr/generate", func(w http.ResponseWriter, r *http.Request) {